From nobody Tue Jul 28 02:17:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h8JyC70kTz6mKRC for ; Tue, 28 Jul 2026 02:17:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h8JyC6VK9z3n9t for ; Tue, 28 Jul 2026 02:17:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785205043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LljQv3MsYzaAybpczWCRbP8DM09wUImDLAOOzy09d3E=; b=xQK6myUpRbGojK7TlvgQRWwfpzDD88z2B7VYY9nSwPK9fzQBsMgPMMlaweKOLoTSubxaut VzhlpN/4fY1Pn+RpXyy3kXumZpils4c4Wi36+vmwR9zU68WyJlP/lp/fCoDraT5ubhbksr robG5ksNKBV6COfWsLuK4lyDsee63LKTcl15k8y9D9+vr+QQQvyGMtdVHed4z95slczPhV biEPlreOTbkz4gZS2L6BY7RGPT8a+Wxvm52z2aquwcuZxrc6kJzODAdEGQKKNZNaHsFXrf +RPvG298nSuL5P2pFr7UUtkbB3PdeFlqo9RoSQ6G8nh1T9c0ghgMStqhzmOkOw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785205043; a=rsa-sha256; cv=none; b=puzbIYIinCXZks67ImEXMlmia6NuYFreH7vacjeZR/T6Sbz3wbhcLeG9lvrlEyTCcmu06F SDiTZcf7mLeExMAxAV6AzGIhfF6IiURPR+iWlV3GVnqyD8mP9jup+aZpBdHZfWF8r3Z14o uXLcddUdVnBaiHMkA/z8l/F6/ZEiu9h9mgxIbW4XUFQV2xSk9Lr1VpyAWE4CIVguquCQGg vnljzZS9QeQM8nxEw0rGfR/6IOXdZA3xFGX3kPmnQb9AcnV3fjp4qoQhcNhgGBLc54q7bw KMqodr9IcBGkbAmQ3XnCC+fLjM5+UgxYOB/cUwkyPnT4A14RcHcsgu/fh950eg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785205043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LljQv3MsYzaAybpczWCRbP8DM09wUImDLAOOzy09d3E=; b=Td6eJZc5lM7pjp98emTRq/2RsV58FvhrrgAlVcoAWZlJjOnVrIHBHxN+4ANDu+Y+hRhoKE JVfTKJ2OsKTnc7L1/E0nBumxqiLPLXWKYoral7JC4GdbwBsGzB7sjzM5mhKeI+xnURUgMF bzZMHBC9g4EidMWv8Ximoosk53HE6MYO2xfbNN5q5mfVXMNNNyEZdSimNw12zjWG9RnI3B O2NGuFPTbdNy2zXqyeU+tnA0KPj6+M1OOMfEN2LdeDVSwH/dkt6fL2BjYqJqHysF7KEPiD Wm+XaEXVh1V+bD8Czsc7Z6IZANddBmek6gGBUnTRmkxGMcoyYG8Hocq4wzGpoA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h8JyC5PDYz4c4 for ; Tue, 28 Jul 2026 02:17:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4545e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 28 Jul 2026 02:17:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 76363a797043 - main - Revert "tests/ktls: merge two sysctl checking helpers into one" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 76363a797043aa2dbbcb0e589146b5002033905a Auto-Submitted: auto-generated Date: Tue, 28 Jul 2026 02:17:18 +0000 Message-Id: <6a68112e.4545e.3dfe4148@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=76363a797043aa2dbbcb0e589146b5002033905a commit 76363a797043aa2dbbcb0e589146b5002033905a Author: Gleb Smirnoff AuthorDate: 2026-07-28 02:16:39 +0000 Commit: Gleb Smirnoff CommitDate: 2026-07-28 02:16:39 +0000 Revert "tests/ktls: merge two sysctl checking helpers into one" With certain sysctl configuration the test will fail. This reverts commit 801c0f383c0a719165c21ff5c29f231fb7b920c4. --- tests/sys/kern/ktls_test.c | 35 +++++++++++++++++++++++++++-------- 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/tests/sys/kern/ktls_test.c b/tests/sys/kern/ktls_test.c index 5cb1a084271b..e0bcf17262f2 100644 --- a/tests/sys/kern/ktls_test.c +++ b/tests/sys/kern/ktls_test.c @@ -51,26 +51,45 @@ #include static void -require_ktls(bool need_rx) +require_ktls(void) { - const char *name = need_rx ? "kern.ipc.tls.rx_enable" : - "kern.ipc.tls.enable"; size_t len; bool enable; len = sizeof(enable); - if (sysctlbyname(name, &enable, &len, NULL, 0) == -1) { + if (sysctlbyname("kern.ipc.tls.enable", &enable, &len, NULL, 0) == -1) { if (errno == ENOENT) atf_tc_skip("kernel does not support TLS offload"); - atf_libc_error(errno, "Failed to read %s", name); + atf_libc_error(errno, "Failed to read kern.ipc.tls.enable"); } if (!enable) - atf_tc_skip("Kernel TLS%s is disabled", need_rx ? " RX" : ""); + atf_tc_skip("Kernel TLS is disabled"); } -#define ATF_REQUIRE_KTLS() require_ktls(false) -#define ATF_REQUIRE_KTLS_RX() require_ktls(true) +#define ATF_REQUIRE_KTLS() require_ktls() + +static void +require_ktls_rx(void) +{ + size_t len; + bool enable; + + ATF_REQUIRE_KTLS(); + + len = sizeof(enable); + if (sysctlbyname("kern.ipc.tls.rx_enable", &enable, &len, NULL, 0) == + -1) { + if (errno == ENOENT) + atf_tc_skip("kernel does not support TLS offload"); + atf_libc_error(errno, "Failed to read kern.ipc.tls.rx_enable"); + } + + if (!enable) + atf_tc_skip("Kernel TLS receive is disabled"); +} + +#define ATF_REQUIRE_KTLS_RX() require_ktls_rx() static void check_tls_mode(const atf_tc_t *tc, int s, int sockopt)