From owner-freebsd-hackers@FreeBSD.ORG  Tue Aug 19 07:09:46 2003
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 01DE616A4BF
	for <hackers@freebsd.org>; Tue, 19 Aug 2003 07:09:46 -0700 (PDT)
Received: from puma.icir.org (puma.icir.org [192.150.187.73])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0D11743F93
	for <hackers@freebsd.org>; Tue, 19 Aug 2003 07:09:45 -0700 (PDT)
	(envelope-from hodson@puma.icir.org)
Received: from puma.icir.org (localhost [127.0.0.1])
	by puma.icir.org (8.12.8p1/8.12.3) with ESMTP id h7JE9eTU013118;
	Tue, 19 Aug 2003 07:09:40 -0700 (PDT)
	(envelope-from hodson@puma.icir.org)
Message-Id: <200308191409.h7JE9eTU013118@puma.icir.org>
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.3
To: Rudolf Cejka <cejkar@fit.vutbr.cz>
From: Orion Hodson <orion@freebsd.org>
In-Reply-To: Your message of "Tue, 19 Aug 2003 09:55:18 +0200."
             <20030819075518.GA75416@fit.vutbr.cz> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Tue, 19 Aug 2003 07:09:40 -0700
Sender: hodson@icir.org
cc: hackers@freebsd.org
Subject: Re: ASUS P4P800-VM + AD1980 (Was Re: VIA8235 + AD1980) 
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Aug 2003 14:09:46 -0000

/-- Rudolf Cejka wrote:
| Rudolf Cejka wrote (2003/08/18):
| >   my "another machine" is at home, so I will be sure about your patch
| > tomorrow and I will send you another mail, however it looks reasonably.
| > Maybe just for "defensive programming" wouldn't it be "safer" to switch
| > values instead of assignment? Maybe there are some boards, which can use
| > both outputs...
| 
| So, I have tested your patch (machine with AD1885) and it works for me,
| however it would be really better to switch values instead of assignment
| even in my case just with HP_OUT connected. With an assignment, it is
| possible to control main volume by two independent controls,
| SOUND_MIXER_VOLUME and SOUND_MIXER_MONITOR, and if I change one of them,
| then there is an inconsistency between the real volume state and the other
| control.

Thank you for the info regarding the patch.

Rather than "defensively" assign the input monitor control 
(SOUND_MIXER_MONITOR) to an output, it'd be better to use a separate output 
control, eg add a control for SOUND_MIXER_OGAIN, should it actually be 
necessary.

Cheers
- Orion