From owner-svn-src-head@FreeBSD.ORG Thu Jan 17 18:40:53 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 2779B3D3; Thu, 17 Jan 2013 18:40:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 03376944; Thu, 17 Jan 2013 18:40:53 +0000 (UTC) Received: from pakbsde14.localnet (unknown [38.105.238.108]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2CB7CB953; Thu, 17 Jan 2013 13:40:52 -0500 (EST) From: John Baldwin To: Eitan Adler Subject: Re: svn commit: r245506 - head/bin/pwait Date: Thu, 17 Jan 2013 10:50:07 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; ) References: <201301161815.r0GIFQPk007553@svn.freebsd.org> <20130117130740.I1066@besplex.bde.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201301171050.07596.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 17 Jan 2013 13:40:52 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI , Bruce Evans X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2013 18:40:53 -0000 On Wednesday, January 16, 2013 10:40:51 pm Eitan Adler wrote: > On 16 January 2013 21:25, Bruce Evans wrote: > > This uses the sysexits mistake. style(9) was fixed to not give an example > > of this mistake. Before this, sysexits was used a whole once in pwait(1) > > (for EX_USAGE) in usage(). EX_USAGE happens to be 64. As usual when the > > mistake is used, this is useless for humans (the usage message gives more > > info) and unusable for programs, especially since it is undocmented > > (pwait(1)'s man page just says ">0 if an error occurs". It doesn't even > > use '.Std' for this, but hard-codes it. > > IMHO using sysexits gives more signal than using a binary 0 or 1. It > is a mistake to have changed style(9) to avoid using sysexits. > Instead the man page should detail the specific error that occurs > directly, or by reference to sysexit. Eh, I think bde@ has quite a bit more experience with this than you. is not part of POSIX or any other standard. It's comments reference delivermail (the predecessor to sendmail). Looking at its history, it has never been changed in FreeBSD, and it's history in CSRG is rather spartan and mostly tied to delivermail/sendmail: http://svnweb.freebsd.org/csrg/include/sysexits.h?view=log In practice it's list of error value is limited and has not grown to handle new errors in over two decades (as opposed to, say, the list of errnos). OTOH, it seems the history section in sysexits(3) is slightly off as the CSRG history suggests it was present in at least 4.2BSD. -- John Baldwin