Date: Wed, 16 Jan 2008 07:00:06 GMT From: Maxim Konovalov <maxim@macomnet.ru> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/119705: [PATCH] make iostat a bit smarter about the number of tty rows Message-ID: <200801160700.m0G706cH057390@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/119705; it has been noted by GNATS.
From: Maxim Konovalov <maxim@macomnet.ru>
To: Giorgos Keramidas <keramida@freebsd.org>
Cc: Bruce Evans <bde@freebsd.org>, bug-followup@freebsd.org
Subject: Re: bin/119705: [PATCH] make iostat a bit smarter about the number
of tty rows
Date: Wed, 16 Jan 2008 09:29:16 +0300 (MSK)
Hi Giorgos,
It seems for me you forget to clear wresized flag -- I added
printf("%s\n", __func__); at the beginning of doresize() to notice
this.
IMHO the isatty() check doesn't belong to a pseudo signal handler
doresize(). Install SIGWINCH handler if and only if stdout is a tty.
Do you have plans to add this feature to netstat, vmstat and all other
similar tools? :-)
--
Maxim Konovalov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801160700.m0G706cH057390>