Date: Tue, 11 Jul 2023 20:16:59 +0200 From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: "Hurling, Rainer" <rhurlin@FreeBSD.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used Message-ID: <5bd4df5587c773d3e8916fe64d093f2b96e67e24.camel@FreeBSD.org> In-Reply-To: <4701f862-7a0b-afab-48fd-a62b6f5ec308@gwdg.de> References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> <CAFDf7UJRc4bd3XVq%2Bb7Za2cLN7h_hkN1mpPTGQiSajV1p9A=0g@mail.gmail.com> <ebcdf01a-2b73-39c3-b6e4-25659e53b1ca@gwdg.de> <e56d377d0985b86be2291b64bb3c686742283dde.camel@FreeBSD.org> <6cf6a5eb00dfac8358dfcb1e1d5b69f293c3e85a.camel@FreeBSD.org> <4701f862-7a0b-afab-48fd-a62b6f5ec308@gwdg.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2023-07-06 at 20:48 +0200, Rainer Hurling wrote: > Am 06.07.23 um 10:51 schrieb Raphael Kubo da Costa: > > > As for a PORTREVISION bump: it _could_ be the case that the > > > generated > > > files differ now, as in the past the default standard was gnu++14 > > > rather than c++11. For leaf ports like these two I don't think > > > the > > > difference really matters, but I've been semi-abstent for so long > > > that > > > portmgr@ or someone more active may have a better guideline. > >=20 > > By the way, one other possibility that I haven't tested myself if > > compatibility is an issue would be doing something like > > https://cgit.freebsd.org/ports/commit/?id=3D4e0c2ae319222145ab0b3f37c0b= a52f596426d5a > >=20 > > but passing USE_STDCXX=3Dgnu++14 instead of changing CXXFLAGS. This > > would > > guarantee that non-main with older clang releases remain untouched > > while also making clang 16 use the same standard that the older > > clang > > releases use. >=20 > Since the eboard project is hardly maintained, an upstream patch is=20 > currently difficult to implement. Therefore I consider to take the > tip=20 > to heart and to change to USE_STDCXX=3Dgnu++14 in the games/eboard > port.=20 > The port builds well, the program seems to work without errors. >=20 > Still, one more question: is it safe to remove USES=3Dcompiler:c++11- > lang=20 > for architectures other than amd64 and i386 and just use=20 > USE_STDCXX=3Dgnu++14. I have no way to test for arm, etc. Nuno asked about this in https://reviews.freebsd.org/D40939 a while ago, and pkubaj@ explained in which situations those keywords (or at least some of them) are required: https://reviews.freebsd.org/D40939#932674 By having those entries, you basically ensure the port builds on FreeBSD 12 for Tier 2 architectures like powerpc and powerpc64 which still use GCC 4.2 on FreeBSD 12.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5bd4df5587c773d3e8916fe64d093f2b96e67e24.camel>