From owner-freebsd-ports-bugs@freebsd.org Sun Jan 17 14:56:08 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAD57A855DB for ; Sun, 17 Jan 2016 14:56:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C145B1A74 for ; Sun, 17 Jan 2016 14:56:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u0HEu8SV024098 for ; Sun, 17 Jan 2016 14:56:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 206337] Fix devel/dee build with clang 3.8.0 Date: Sun, 17 Jan 2016 14:56:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: olivierd@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2016 14:56:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206337 Bug ID: 206337 Summary: Fix devel/dee build with clang 3.8.0 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: olivierd@FreeBSD.org Reporter: dim@FreeBSD.org Assignee: olivierd@FreeBSD.org Flags: maintainer-feedback?(olivierd@FreeBSD.org) Created attachment 165718 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D165718&action= =3Dedit Parenthesize journal_iter_is_removed macro so it doesn't cause warnings During the exp-run in bug 206074, it was found that devel/dee gives errors = with a recent clang 3.8.0 snapshot: dee-transaction.c:1245:17: error: logical not is only applied to the left h= and side of this comparison [-Werror,-Wlogical-not-parentheses] g_assert (!journal_iter_is_removed (jiter)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/local/include/glib-2.0/glib/gtestutils.h:106:59: note: expanded from m= acro 'g_assert' if G_LIKELY (expr) ; else \ ^~~~ /usr/local/include/glib-2.0/glib/gmacros.h:325:59: note: expanded from macro 'G_LIKELY' #define G_LIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR(expr), 1)) ^~~~ /usr/local/include/glib-2.0/glib/gmacros.h:319:8: note: expanded from macro '_G_BOOLEAN_EXPR' if (expr) \ ^~~~ dee-transaction.c:1245:17: note: add parentheses after the '!' to evaluate = the comparison first dee-transaction.c:1245:17: note: add parentheses around left hand side expression to silence this warning 1 error generated. This is because the journal_iter_is_removed() macro does not have parenthes= es around its expression. Here is a patch to fix that. --=20 You are receiving this mail because: You are the assignee for the bug.=