From owner-cvs-doc@FreeBSD.ORG Thu Sep 25 09:24:37 2003 Return-Path: Delivered-To: cvs-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE82716A4B3; Thu, 25 Sep 2003 09:24:37 -0700 (PDT) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A4894401A; Thu, 25 Sep 2003 09:24:36 -0700 (PDT) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) h8PGOSus012915; Thu, 25 Sep 2003 12:24:28 -0400 (EDT) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id h8PGOSGs012914; Thu, 25 Sep 2003 12:24:28 -0400 (EDT) Date: Thu, 25 Sep 2003 12:24:28 -0400 From: Ken Smith To: Josef El-Rayes Message-ID: <20030925162427.GA12579@electra.cse.Buffalo.EDU> References: <200309251252.h8PCq7Tc093693@repoman.freebsd.org> <20030925152525.GA410@daemon.li> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030925152525.GA410@daemon.li> User-Agent: Mutt/1.4.1i cc: cvs-all@FreeBSD.org cc: doc-committers@FreeBSD.org cc: cvs-doc@FreeBSD.org cc: Ken Smith Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml X-BeenThere: cvs-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the doc and www trees List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2003 16:24:37 -0000 On Thu, Sep 25, 2003 at 05:25:25PM +0200, Josef El-Rayes wrote: > Ken Smith wrote: > > - "whitespace change" that coverts existing driver example code > > to be style(9) compliant, matching format of new driver code > > for me this is strange, i always thought that we do not do patches which > do whitespace changes only - which does make the repository bigger > without any real benefit. > is there a special reason why we do this here? In this case there is a special reason - the whitespace adjustments are visible to the users. I was adjusting whitespace inside of a program example. Someone else mentioned this as well, I was making it style(9) compliant. IMO if the people who watch over the source code commits are going to "insist" on style(9) compliance we should make an effort for the examples in the online documentation to also be style(9) compliant. Should I phrase the commit log message in a different way if this sort of thing happens again? Strictly speaking because the whitespace changes are visible in the end result you could consider this a real functional change. People tend to associate "whitespace change" with "will be eaten by the SGML processors and makes no visible change in the end result" but in cases like this that is not the case. -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel |