From owner-p4-projects@FreeBSD.ORG  Sun May 30 19:03:52 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id F15161065672; Sun, 30 May 2010 19:03:51 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5683106564A
	for <perforce@freebsd.org>; Sun, 30 May 2010 19:03:51 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe08.swip.net [212.247.154.225])
	by mx1.freebsd.org (Postfix) with ESMTP id 42B6C8FC13
	for <perforce@freebsd.org>; Sun, 30 May 2010 19:03:50 +0000 (UTC)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=69Y28RYJ0wkA:10 a=ADBQPqJMlbwA:10
	a=8nJEP1OIZ-IA:10 a=M8b_wTzEtboA:10
	a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=640_ClquSogFsllnLYQA:9
	a=FmyafZfeApoW0v_TfYiKQ1TKOz4A:4 a=wPNLvfGTeEIA:10
Received: from [188.126.201.140] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe08.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 1362462525; Sun, 30 May 2010 21:03:48 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: Garrett Cooper <gcooper@freebsd.org>
Date: Sun, 30 May 2010 21:01:02 +0200
User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.4; amd64; ; )
References: <201005301444.o4UEidHb057496@repoman.freebsd.org>
	<AANLkTilpZTmKr3tTrfafgt5CtskJB3LMEM_XoOsJdKq2@mail.gmail.com>
In-Reply-To: <AANLkTilpZTmKr3tTrfafgt5CtskJB3LMEM_XoOsJdKq2@mail.gmail.com>
X-Face: +~\`s("[*<S!NI[0M*"FaghA8S>|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'(
	=?iso-8859-1?q?=3B=5FIjlA=3A=0A=09hGE=2E=2EEw?=,
	=?iso-8859-1?q?XAQ*o=23=5C/M=7ESC=3DS1-f9=7BEzRfT=27=7CHhll5Q=5Dha5Bt-s=7Co?=
	=?iso-8859-1?q?TlKMusi=3A1e=5BwJl=7Dkd=7DGR=0A=09Z0adGx-x=5F0zGbZj=27e?=(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L'
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201005302101.02794.hselasky@c2i.net>
Cc: Perforce Change Reviews <perforce@freebsd.org>, Marko Zec <zec@freebsd.org>
Subject: Re: PERFORCE change 178978 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 May 2010 19:03:52 -0000

On Sunday 30 May 2010 20:59:33 Garrett Cooper wrote:
> >     if (version != 1)
> > -       return (ENOPROTOOPT);
> > +       return ENOPROTOOPT;
> 
> That's actually a style regression (along with any other return calls
> without parentheses).
> 

FYI:

Linux style mandatates return values without parentheses. And FreeBSD style 
mandates that opposite!

--HPS