Date: Sun, 30 May 2010 21:01:02 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: Garrett Cooper <gcooper@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org>, Marko Zec <zec@freebsd.org> Subject: Re: PERFORCE change 178978 for review Message-ID: <201005302101.02794.hselasky@c2i.net> In-Reply-To: <AANLkTilpZTmKr3tTrfafgt5CtskJB3LMEM_XoOsJdKq2@mail.gmail.com> References: <201005301444.o4UEidHb057496@repoman.freebsd.org> <AANLkTilpZTmKr3tTrfafgt5CtskJB3LMEM_XoOsJdKq2@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 30 May 2010 20:59:33 Garrett Cooper wrote: > > if (version != 1) > > - return (ENOPROTOOPT); > > + return ENOPROTOOPT; > > That's actually a style regression (along with any other return calls > without parentheses). > FYI: Linux style mandatates return values without parentheses. And FreeBSD style mandates that opposite! --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005302101.02794.hselasky>