From owner-svn-src-head@FreeBSD.ORG Sat Nov 1 10:30:31 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22C8B1065673; Sat, 1 Nov 2008 10:30:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id B677F8FC12; Sat, 1 Nov 2008 10:30:30 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1KwDkS-0004LP-Qz; Sat, 01 Nov 2008 12:30:28 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mA1AUPCu053137 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 1 Nov 2008 12:30:25 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mA1AUPk2034902; Sat, 1 Nov 2008 12:30:25 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mA1AUPZH034901; Sat, 1 Nov 2008 12:30:25 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 1 Nov 2008 12:30:25 +0200 From: Kostik Belousov To: Warner Losh Message-ID: <20081101103025.GU18100@deviant.kiev.zoral.com.ua> References: <200810312324.m9VNOE88093395@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xdFnWCcMW4kMaGnb" Content-Disposition: inline In-Reply-To: <200810312324.m9VNOE88093395@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1KwDkS-0004LP-Qz 4cac31941f32609220dbf0f125f91a04 X-Terabit: YES Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184515 - in head/sys: conf modules/rl pci X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Nov 2008 10:30:31 -0000 --xdFnWCcMW4kMaGnb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 31, 2008 at 11:24:14PM +0000, Warner Losh wrote: > Author: imp > Date: Fri Oct 31 23:24:13 2008 > New Revision: 184515 > URL: http://svn.freebsd.org/changeset/base/184515 >=20 > Log: > Add RL_TWISTER_ENABLE option. This enables the magic bits to do long > cable tuning. This has helped in some installations for hardware > deployed by a former employer. Made optional because the lists aren't > full of complaints about these cards... even when they were wildly > popular. > =20 > Reviewed by: attilio@, jhb@, trhodes@ (all an older version of the patc= h) >=20 > Modified: > head/sys/conf/options > head/sys/modules/rl/Makefile > head/sys/pci/if_rl.c > head/sys/pci/if_rlreg.h >=20 > Modified: head/sys/conf/options > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/conf/options Fri Oct 31 18:40:35 2008 (r184514) > +++ head/sys/conf/options Fri Oct 31 23:24:13 2008 (r184515) > @@ -672,6 +672,9 @@ ED_SIC opt_ed.h > # bce driver > BCE_DEBUG opt_bce.h > =20 > +# rl driver > +RL_TWISTER_ENABLE opt_rl.h Would it make sense to compile it unconditionally, but enable by a sysctl or loader knob ? --xdFnWCcMW4kMaGnb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkkML8AACgkQC3+MBN1Mb4joZACfbzNsZ3L73wv45JjcAvaYv5Ne j+0An2UfRj86WoE3K2DAQtiU7bkRvN09 =yHwE -----END PGP SIGNATURE----- --xdFnWCcMW4kMaGnb--