From owner-cvs-sbin Thu Feb 5 08:11:08 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA09485 for cvs-sbin-outgoing; Thu, 5 Feb 1998 08:11:08 -0800 (PST) (envelope-from owner-cvs-sbin) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA09211; Thu, 5 Feb 1998 08:10:27 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id DAA12131; Fri, 6 Feb 1998 03:05:25 +1100 Date: Fri, 6 Feb 1998 03:05:25 +1100 From: Bruce Evans Message-Id: <199802051605.DAA12131@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sbin@FreeBSD.ORG, jhay@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/fsck Makefile src/sbin/fsdb Makefile Cc: v@godzilla.zeta.org.au Sender: owner-cvs-sbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified files: > sbin/fsck Makefile > sbin/fsdb Makefile > Log: > fsdb and fsck use the ffs code which needs opt_diagnostic.h. The ffs code shouldn't include opt_diagnostic.h unless KERNEL is defined. In fact, it shouldn't include opt_diagnostic.h or test DIAGNOSTIC or KERNEL at all. The relevant diagnostic code is only callable from a debugger, so it should only depend on DDB. Bruce