From owner-cvs-all Tue Nov 19 21:44:19 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A07937B404 for ; Tue, 19 Nov 2002 21:44:18 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 3815443E8A for ; Tue, 19 Nov 2002 21:44:14 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 62429 invoked by uid 1000); 20 Nov 2002 05:44:16 -0000 Date: Tue, 19 Nov 2002 21:44:16 -0800 (PST) From: Nate Lawson To: Kris Kennaway Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c scsi_cd.h src/sys/dev/ata atapi-cd.c src/sys/sys cdrio.h src/usr.sbin/burncd burncd.8 burncd.c src/usr.sbin/cdcontrol cdcontrol.1 cdcontrol.c In-Reply-To: <20021120022910.GA7969@rot13.obsecurity.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 19 Nov 2002, Kris Kennaway wrote: > On Tue, Nov 19, 2002 at 06:18:59PM -0800, Nate Lawson wrote: > > > See the HEADSUP on stable@ and ports@. Only people who were using the > > FreeBSD-only ioctls need to change, simply by multiplying by 177 (the > > kernel was doing this conversion before). API is preserved although units > > have changed. > > Also, what will happen when someone uses an old 4.x binary that calls > these ioctls on 5.0? > > Kris I will commit a one-line addition that if the value is less than 177, scale it appropriately. This change won't hurt the new API and maintaining ABI is nice. However, I'm a little dismayed at the review process here. The change has been in -current for a month with a message saying it would be MFCd in a month. Not one of the negative comments on the MFC has indicated a single application outside of our tree that uses our _FreeBSD_only_ ioctl API. Neither of the two maintainers who reviewed the patch had a problem with it. Why didn't you express your concerns earlier? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message