From owner-freebsd-bugs@FreeBSD.ORG Fri Apr 15 18:20:09 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E7721065672 for ; Fri, 15 Apr 2011 18:20:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D17DF8FC16 for ; Fri, 15 Apr 2011 18:20:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3FIK8nc090197 for ; Fri, 15 Apr 2011 18:20:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p3FIK82P090196; Fri, 15 Apr 2011 18:20:08 GMT (envelope-from gnats) Resent-Date: Fri, 15 Apr 2011 18:20:08 GMT Resent-Message-Id: <201104151820.p3FIK82P090196@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eugene Grosbein Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C08C0106566C for ; Fri, 15 Apr 2011 18:12:43 +0000 (UTC) (envelope-from eugen@grosbein.pp.ru) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [62.231.161.221]) by mx1.freebsd.org (Postfix) with ESMTP id 2FF0C8FC1C for ; Fri, 15 Apr 2011 18:12:42 +0000 (UTC) Received: from grosbein.pp.ru (188-123-32-240.rdtc.ru [188.123.32.240] (may be forged)) by eg.sd.rdtc.ru (8.14.4/8.14.4) with ESMTP id p3FICe15016751; Sat, 16 Apr 2011 01:12:40 +0700 (NOVST) (envelope-from eugen@grosbein.pp.ru) Received: from grosbein.pp.ru (localhost [127.0.0.1]) by grosbein.pp.ru (8.14.4/8.14.4) with ESMTP id p3FIBOns002960; Sat, 16 Apr 2011 01:11:24 +0700 (NOVST) (envelope-from eugen@grosbein.pp.ru) Received: (from eugen@localhost) by grosbein.pp.ru (8.14.4/8.14.4/Submit) id p3FIBOgd002959; Sat, 16 Apr 2011 01:11:24 +0700 (NOVST) (envelope-from eugen) Message-Id: <201104151811.p3FIBOgd002959@grosbein.pp.ru> Date: Sat, 16 Apr 2011 01:11:24 +0700 (NOVST) From: Eugene Grosbein To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: dougb@FreeBSD.org Subject: misc/156427: rcNG may start disabled service X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eugene Grosbein List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2011 18:20:09 -0000 >Number: 156427 >Category: misc >Synopsis: rcNG may start disabled service >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 15 18:20:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Eugene Grosbein >Release: FreeBSD 8.2-STABLE i386 >Organization: RDTC JSC >Environment: System: FreeBSD grosbein.pp.ru 8.2-STABLE FreeBSD 8.2-STABLE #21: Sat Apr 9 16:26:00 NOVST 2011 root@grosbein.pp.ru:/usr/local/obj/usr/local/src/sys/DADV i386 >Description: For some services I prefer using service_enable="NO" in /etc/rc.conf and start them by other means when needed using "forcestart" feature. SVN r206686 and MFC r207797 broke this: now rc.subr at boot time starts disabled service if it is already started by other means ($rc_pid is not empty). So, the service sometimes get started twice that's not good for me. >How-To-Repeat: 1. Disable any installed service using servicename="NO" in /etc/rc.conf 2. Run it at boot time by another script (I need service be started or not depending on results of some local tests). 3. See it's started twice. >Fix: Mentioned change occured to make 'stop' work even if ${name}_enable is not set. The code should check whether it's started to 'stop'. >Release-Note: >Audit-Trail: >Unformatted: