From owner-freebsd-fs@FreeBSD.ORG  Thu Jan 22 15:21:12 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6F9E3106566C
	for <freebsd-fs@freebsd.org>; Thu, 22 Jan 2009 15:21:12 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 30B3D8FC17
	for <freebsd-fs@freebsd.org>; Thu, 22 Jan 2009 15:21:12 +0000 (UTC)
	(envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id EAF686D43F;
	Thu, 22 Jan 2009 15:21:10 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id D1060844C2; Thu, 22 Jan 2009 16:21:10 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Andrew Brampton <brampton+freebsd-fs@gmail.com>
References: <d41814900901181701n7928e40cv2aa1dc4dff582fda@mail.gmail.com>
	<868wp4pqwm.fsf@ds4.des.no>
	<d41814900901210937y390cdff3pf6a9551df2c4bcd3@mail.gmail.com>
Date: Thu, 22 Jan 2009 16:21:10 +0100
In-Reply-To: <d41814900901210937y390cdff3pf6a9551df2c4bcd3@mail.gmail.com>
	(Andrew Brampton's message of "Wed, 21 Jan 2009 17:37:43 +0000")
Message-ID: <86iqo74ba1.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-fs@freebsd.org
Subject: Re: Pseudofs and pfs_attr_t for non-process based files
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jan 2009 15:21:12 -0000

Andrew Brampton <brampton+freebsd-fs@gmail.com> writes:
> Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
> > Sounds sensible, but your patches are mangled.  Could you please
> > regenerate them using 'svn diff -x-p' on a non-Windows machine?
> When you say mangled, did you just mean they had windows new lines?

That, and incorrect indentation, which your new patches fixed.

A tip: if your MUA allows it, set the MIME-type for patches to
text/x-patch (or, as last resort, text/plain), otherwise they may get
stripped by mailing list software and some corporate / institutional
email gateways.

In procfs_attr(), the vap->va_[ug]id assignments are redundant, since at
this point pfs_getattr() has already done the exact same thing.  The
rest of the patch is fine, modulo style issues which already existed in
my code.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no