From owner-svn-ports-all@FreeBSD.ORG  Tue Sep  4 16:36:24 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by hub.freebsd.org (Postfix) with ESMTP id 15C7E1065670;
	Tue,  4 Sep 2012 16:36:24 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id F18BA14E9C4;
	Tue,  4 Sep 2012 16:35:55 +0000 (UTC)
Message-ID: <50462DEC.3040202@FreeBSD.org>
Date: Tue, 04 Sep 2012 09:35:56 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Mozilla/5.0 (Windows NT 5.1;
	rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: Florian Smeets <flo@smeets.im>
References: <201209032233.q83MXSa2053725@svn.freebsd.org>
	<50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org>
	<50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org>
	<5045E904.5080608@smeets.im>
In-Reply-To: <5045E904.5080608@smeets.im>
X-Enigmail-Version: 1.4.3
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: svn commit: r303626 - head/www/xpi-firebug
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Sep 2012 16:36:24 -0000

On 9/4/2012 4:41 AM, Florian Smeets wrote:

> I still see this as a style nit. Can you be a bit more specific where
> portmaster fails with distinfo (or other files) not having the last
> newline?

I already explained it twice. :)

Take a file with no newline at the end. Do this:

while read line ; do
	echo $line
done < badfile

The last line will not be "seen" by the shell because of the missing
newline.

Portmaster, and other tools, use this method extensively to read those
files, and this issue causes those tools to break while processing those
files.

Doug

-- 

    I am only one, but I am one.  I cannot do everything, but I can do
    something.  And I will not let what I cannot do interfere with what
    I can do.
			-- Edward Everett Hale, (1822 - 1909)