Date: Tue, 04 Sep 2012 09:35:56 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Florian Smeets <flo@smeets.im> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303626 - head/www/xpi-firebug Message-ID: <50462DEC.3040202@FreeBSD.org> In-Reply-To: <5045E904.5080608@smeets.im> References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <5045E904.5080608@smeets.im>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/4/2012 4:41 AM, Florian Smeets wrote:
> I still see this as a style nit. Can you be a bit more specific where
> portmaster fails with distinfo (or other files) not having the last
> newline?
I already explained it twice. :)
Take a file with no newline at the end. Do this:
while read line ; do
echo $line
done < badfile
The last line will not be "seen" by the shell because of the missing
newline.
Portmaster, and other tools, use this method extensively to read those
files, and this issue causes those tools to break while processing those
files.
Doug
--
I am only one, but I am one. I cannot do everything, but I can do
something. And I will not let what I cannot do interfere with what
I can do.
-- Edward Everett Hale, (1822 - 1909)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50462DEC.3040202>