From owner-cvs-all  Thu Jun 13 11:12:34 2002
Delivered-To: cvs-all@freebsd.org
Received: from hex.databits.net (hex.csh.rit.edu [129.21.60.134])
	by hub.freebsd.org (Postfix) with ESMTP
	id E738B37B403; Thu, 13 Jun 2002 11:12:26 -0700 (PDT)
Received: by hex.databits.net (Postfix, from userid 1001)
	id 526A921115; Thu, 13 Jun 2002 14:12:26 -0400 (EDT)
Date: Thu, 13 Jun 2002 14:12:26 -0400
From: Pete Fritchman <petef@absolutbsd.org>
To: Mikhail Teterin <mi+mx@aldan.algebra.com>
Cc: Maxim Sobolev <sobomax@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re:  cvs commit: ports/x11-toolkits/eel2/files patch-Makefile.in
Message-ID: <20020613141226.A55226@absolutbsd.org>
References: <200206131606.g5DG6PW29106@freefall.freebsd.org> <200206131402.14393.mi+mx@aldan.algebra.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200206131402.14393.mi+mx@aldan.algebra.com>; from mi+mx@aldan.algebra.com on Thu, Jun 13, 2002 at 02:02:14PM -0400
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

++ 13/06/02 14:02 -0400 - Mikhail Teterin:
| On Thursday 13 June 2002 12:06 pm, Maxim Sobolev wrote:
| = sobomax     2002/06/13 09:06:25 PDT
| =
| =   Added files:
| =     x11-toolkits/eel2/files patch-Makefile.in
| =   Log:
| =   Don't bother to build tests which aren't installed anyway.
| 
| Wouldn't it be better to modify the port to _run_ the tests after
| the build? Speak of QA skills...

That should probably be left up to the maintainer to do before
committing the port... for example, none of the p5-* ports run a "make
test" during the build stage, but before I ever commit a new/updated p5
port I run a "make test" to see that it works OK...

Perhaps we should adopt OpenBSD's testing/regress infrastructure for
ports?

--pete

--
Pete Fritchman [petef@(databits.net|freebsd.org|csh.rit.edu)]
finger petef@databits.net for PGP key

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message