From owner-freebsd-fs@FreeBSD.ORG Tue Oct 9 09:11:41 2012 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5051E633 for ; Tue, 9 Oct 2012 09:11:41 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 85CC38FC14 for ; Tue, 9 Oct 2012 09:11:40 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA05257 for ; Tue, 09 Oct 2012 12:11:39 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1TLVqk-000GLI-PA for freebsd-fs@freebsd.org; Tue, 09 Oct 2012 12:11:38 +0300 Resent-From: Andriy Gapon Resent-To: "freebsd-fs@freebsd.org" Resent-Date: Tue, 9 Oct 2012 12:11:38 +0300 Resent-Message-Id: <5073EA4A.5020100@FreeBSD.org> Resent-User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:15.0) Gecko/20120913 Thunderbird/15.0.1 Message-ID: <5073E136.5090707@FreeBSD.org> Date: Tue, 09 Oct 2012 11:32:54 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:15.0) Gecko/20120913 Thunderbird/15.0.1 MIME-Version: 1.0 To: "Justin T. Gibbs" Subject: Re: ZFS: Deadlock during vnode recycling References: <76CBA055-021F-458D-8978-E9A973D9B783@scsiguy.com> <506EB43B.8050204@FreeBSD.org> <5071A071.1020800@FreeBSD.org> <97D56E7F-1284-4FB1-8C83-9EE04FE4F59F@scsiguy.com> In-Reply-To: <97D56E7F-1284-4FB1-8C83-9EE04FE4F59F@scsiguy.com> X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Konstantin Belousov , fs@FreeBSD.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2012 09:11:41 -0000 on 07/10/2012 21:44 Justin T. Gibbs said the following: > On Oct 7, 2012, at 9:32 AM, Andriy Gapon wrote: > >> In fact here is a real patch that I would like to propose: >> http://people.freebsd.org/~avg/zfs-getnewvnode_reserve.diff > > OS-X has these same types of problems and I talked with Don Brady > of the OS-X ZFS port about them during ZFS day. It sounds like he > explicitly pre-allocates vnodes in these code paths instead of > relying on a reserve pool. How is pre-allocation different from reservation? Terminologically it looks like different words for the same thing. > I plan to review his work since I expect > he's found and fixed problems we don't even know we have yet. That would be very interesting to learn. > My only complaint with this patch is that it doesn't include stats > counters for these rare conditions so that I can validate that the > code is exercised during a test suite. Can you merge in the kstat > portion of the change I proposed? Umm, I was not planning on doing that... Your last patch looked rather big. If we decide that including those stats in that way into the tree is a way to go, then I will try to look into doing that. Unless you beat me to it. P.S. it is not fact that the patch of mine could go into the tree, of course :-) -- Andriy Gapon