Date: Tue, 09 Oct 2012 11:32:54 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: "Justin T. Gibbs" <gibbs@scsiguy.com> Cc: Konstantin Belousov <kib@FreeBSD.org>, fs@FreeBSD.org Subject: Re: ZFS: Deadlock during vnode recycling Message-ID: <5073E136.5090707@FreeBSD.org> Resent-Message-ID: <5073EA4A.5020100@FreeBSD.org> In-Reply-To: <97D56E7F-1284-4FB1-8C83-9EE04FE4F59F@scsiguy.com> References: <76CBA055-021F-458D-8978-E9A973D9B783@scsiguy.com> <506EB43B.8050204@FreeBSD.org> <5071A071.1020800@FreeBSD.org> <97D56E7F-1284-4FB1-8C83-9EE04FE4F59F@scsiguy.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 07/10/2012 21:44 Justin T. Gibbs said the following: > On Oct 7, 2012, at 9:32 AM, Andriy Gapon <avg@FreeBSD.org> wrote: > >> In fact here is a real patch that I would like to propose: >> http://people.freebsd.org/~avg/zfs-getnewvnode_reserve.diff > > OS-X has these same types of problems and I talked with Don Brady > of the OS-X ZFS port about them during ZFS day. It sounds like he > explicitly pre-allocates vnodes in these code paths instead of > relying on a reserve pool. How is pre-allocation different from reservation? Terminologically it looks like different words for the same thing. > I plan to review his work since I expect > he's found and fixed problems we don't even know we have yet. That would be very interesting to learn. > My only complaint with this patch is that it doesn't include stats > counters for these rare conditions so that I can validate that the > code is exercised during a test suite. Can you merge in the kstat > portion of the change I proposed? Umm, I was not planning on doing that... Your last patch looked rather big. If we decide that including those stats in that way into the tree is a way to go, then I will try to look into doing that. Unless you beat me to it. P.S. it is not fact that the patch of mine could go into the tree, of course :-) -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5073E136.5090707>