From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jul 19 21:10:12 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ADDE01065673 for ; Thu, 19 Jul 2012 21:10:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6DE558FC17 for ; Thu, 19 Jul 2012 21:10:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q6JLACHZ012071 for ; Thu, 19 Jul 2012 21:10:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q6JLACee012070; Thu, 19 Jul 2012 21:10:12 GMT (envelope-from gnats) Resent-Date: Thu, 19 Jul 2012 21:10:12 GMT Resent-Message-Id: <201207192110.q6JLACee012070@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Chris Rees Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1A7811065670 for ; Thu, 19 Jul 2012 21:04:51 +0000 (UTC) (envelope-from crees@bayofrum.net) Received: from mk-outboundfilter-1.mail.uk.tiscali.com (mk-outboundfilter-1.mail.uk.tiscali.com [212.74.114.37]) by mx1.freebsd.org (Postfix) with ESMTP id 9D0838FC1C for ; Thu, 19 Jul 2012 21:04:50 +0000 (UTC) Received: from host-2-102-4-87.as13285.net (HELO pegasus.bayofrum.net) ([2.102.4.87]) by smtp.pipex.tiscali.co.uk with ESMTP; 19 Jul 2012 22:03:31 +0100 Received: by pegasus.bayofrum.net (Postfix, from userid 1001) id D9F2910F08; Thu, 19 Jul 2012 22:03:21 +0100 (BST) Message-Id: <20120719210321.D9F2910F08@pegasus.bayofrum.net> Date: Thu, 19 Jul 2012 22:03:21 +0100 (BST) From: Chris Rees To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/170007: [PATCH] dns/unbound Incorrect use of empty() X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris Rees List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2012 21:10:12 -0000 >Number: 170007 >Category: ports >Synopsis: [PATCH] dns/unbound Incorrect use of empty() >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jul 19 21:10:11 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Chris Rees >Release: FreeBSD 9.0-RELEASE amd64 >Organization: >Environment: System: FreeBSD pegasus.bayofrum.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Sun Apr 29 12:29:02 BST 2012 root@pegasus.bayofrum.net:/usr/obj/usr/src/sys/PEGASUS amd64 >Description: .if empty() in a Makefile should not have a $ in; correct: .if empty(FOO) incorrect: .if empty(${FOO}) >How-To-Repeat: >Fix: Submitted by Alexey Kouznetsov --- patch.txt begins here --- Index: Makefile =================================================================== --- Makefile (revision 301190) +++ Makefile (working copy) @@ -88,7 +88,7 @@ CONFIGURE_ARGS+=--with-libevent=no .endif -.if empty(${PORT_OPTIONS:MTHREADS}) +.if empty(PORT_OPTIONS:MTHREADS) CONFIGURE_ARGS+=--without-pthreads .endif --- patch.txt ends here --- >Release-Note: >Audit-Trail: >Unformatted: