From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Apr 25 13:30:09 2007 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A4F2816A401 for ; Wed, 25 Apr 2007 13:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 83F1C13C45E for ; Wed, 25 Apr 2007 13:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l3PDU9sA027550 for ; Wed, 25 Apr 2007 13:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l3PDU99O027549; Wed, 25 Apr 2007 13:30:09 GMT (envelope-from gnats) Resent-Date: Wed, 25 Apr 2007 13:30:09 GMT Resent-Message-Id: <200704251330.l3PDU99O027549@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6812216A407 for ; Wed, 25 Apr 2007 13:28:10 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from cp65.agava.net (cp65.agava.net [89.108.66.215]) by mx1.freebsd.org (Postfix) with ESMTP id 4A00213C48C for ; Wed, 25 Apr 2007 13:28:08 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from clamav by cp65.agava.net with drweb-scanned (Exim 4.44 (FreeBSD)) id 1HghXR-0007CE-2n for FreeBSD-gnats-submit@freebsd.org; Wed, 25 Apr 2007 17:28:05 +0400 Received: from [213.148.29.33] (helo=nexii.panopticon) by cp65.agava.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.44 (FreeBSD)) id 1HghXQ-0007C4-Ut for FreeBSD-gnats-submit@freebsd.org; Wed, 25 Apr 2007 17:28:05 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.2]) by nexii.panopticon (Postfix) with ESMTP id 452A417045 for ; Wed, 25 Apr 2007 17:26:49 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id 12E8C4098; Wed, 25 Apr 2007 17:28:17 +0400 (MSD) Message-Id: <20070425132817.12E8C4098@hades.panopticon> Date: Wed, 25 Apr 2007 17:28:17 +0400 (MSD) From: Dmitry Marakasov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/112118: [PATCH] sysutils/pipemeter: fix crashes X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dmitry Marakasov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2007 13:30:09 -0000 >Number: 112118 >Category: ports >Synopsis: [PATCH] sysutils/pipemeter: fix crashes >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Apr 25 13:30:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 6.1-RELEASE-p12 i386 >Organization: >Environment: System: FreeBSD hades.panopticon 6.1-RELEASE-p12 FreeBSD 6.1-RELEASE-p12 #0: Tue Jan 16 23:12:21 MSK 2007 amdmi3@hades.panopticon:/usr/obj/usr/src/sys/HADES i386 >Description: Pipemeter crashes after some data passes through it: % pipemeter /dev/null [1] 44929 alarm pipemeter < /dev/zero > /dev/null Crash happens because sigaction structure is not filled with zeroes before usage, thus may not be repeatable in some cases (but it crashes under my pentium3, pentiom4 and celeron boxes). Attached patch fixes the crashes. Patch also sent upstream some time ago, but I've got no response. >How-To-Repeat: pipemeter /dev/null >Fix: --- pipemeter.patch begins here --- diff -ruN pipemeter.orig/files/patch-pipemeter.c pipemeter/files/patch-pipemeter.c --- pipemeter.orig/files/patch-pipemeter.c Thu Jan 1 03:00:00 1970 +++ pipemeter/files/patch-pipemeter.c Wed Apr 25 17:16:27 2007 @@ -0,0 +1,10 @@ +--- pipemeter.c.orig Fri Nov 24 17:59:35 2006 ++++ pipemeter.c Fri Nov 24 18:00:55 2006 +@@ -236,6 +236,7 @@ + progressfill[i]=PBRIGHT; + progressfill[i+1]='\0'; + ++ memset(&sa, 0, sizeof(struct sigaction)); + sa.sa_handler= filesize ? show_progress : show_just_rate; + sigaction(SIGTERM, &sa, &sa_orig); + sigaction(SIGINT, &sa, &sa_orig); --- pipemeter.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: