Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Jul 2012 00:23:32 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        David Chisnall <theraven@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r238182 - head/lib/libc/locale
Message-ID:  <20120706212332.GQ2338@deviant.kiev.zoral.com.ua>
In-Reply-To: <20120706211529.GP2338@deviant.kiev.zoral.com.ua>
References:  <201207062016.q66KGM1e080728@svn.freebsd.org> <20120706211529.GP2338@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help

--V2tfspbppmK1TQo2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jul 07, 2012 at 12:15:29AM +0300, Konstantin Belousov wrote:
> On Fri, Jul 06, 2012 at 08:16:22PM +0000, David Chisnall wrote:
> > Author: theraven
> > Date: Fri Jul  6 20:16:22 2012
> > New Revision: 238182
> > URL: http://svn.freebsd.org/changeset/base/238182
> >=20
> > Log:
> >   Restore the __collate_load_error global that was accidentally removed=
 in the
> >   xlocale refactoring.
> >  =20
> I think this commit is wrong, or at least not complete.
> You failed to restore the actual export of the symbol in locale/Symbol.ma=
p.

I stay corrected: the symbol _is_ present in the Symbol.map, sorry. But
it is located in the private version definition, which was the reason
that I did not noticed it, and which changes the status of commit from
"incomplete" to "unneccessary". We do not guarantee anything about
private symbols.

Most likely, it is application error to link to this symbol. If application
use for it is legitimate, then the symbol shall be moved to FBSD_1.3
version.

--V2tfspbppmK1TQo2
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)

iEYEARECAAYFAk/3V1QACgkQC3+MBN1Mb4j1lACghUBU18OTXaSiibHOX00ULEVz
pUYAnjGD6XJaCsqsUMy9j31FqDz2Y6Y2
=sSkP
-----END PGP SIGNATURE-----

--V2tfspbppmK1TQo2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120706212332.GQ2338>