From owner-svn-src-head@FreeBSD.ORG Fri Jul 6 21:24:01 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 86B7B106564A; Fri, 6 Jul 2012 21:24:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id D88918FC0C; Fri, 6 Jul 2012 21:24:00 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q66LNjGg097148; Sat, 7 Jul 2012 00:23:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q66LNWb0020674; Sat, 7 Jul 2012 00:23:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q66LNW85020673; Sat, 7 Jul 2012 00:23:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 7 Jul 2012 00:23:32 +0300 From: Konstantin Belousov To: David Chisnall Message-ID: <20120706212332.GQ2338@deviant.kiev.zoral.com.ua> References: <201207062016.q66KGM1e080728@svn.freebsd.org> <20120706211529.GP2338@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V2tfspbppmK1TQo2" Content-Disposition: inline In-Reply-To: <20120706211529.GP2338@deviant.kiev.zoral.com.ua> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r238182 - head/lib/libc/locale X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2012 21:24:01 -0000 --V2tfspbppmK1TQo2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 07, 2012 at 12:15:29AM +0300, Konstantin Belousov wrote: > On Fri, Jul 06, 2012 at 08:16:22PM +0000, David Chisnall wrote: > > Author: theraven > > Date: Fri Jul 6 20:16:22 2012 > > New Revision: 238182 > > URL: http://svn.freebsd.org/changeset/base/238182 > >=20 > > Log: > > Restore the __collate_load_error global that was accidentally removed= in the > > xlocale refactoring. > > =20 > I think this commit is wrong, or at least not complete. > You failed to restore the actual export of the symbol in locale/Symbol.ma= p. I stay corrected: the symbol _is_ present in the Symbol.map, sorry. But it is located in the private version definition, which was the reason that I did not noticed it, and which changes the status of commit from "incomplete" to "unneccessary". We do not guarantee anything about private symbols. Most likely, it is application error to link to this symbol. If application use for it is legitimate, then the symbol shall be moved to FBSD_1.3 version. --V2tfspbppmK1TQo2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk/3V1QACgkQC3+MBN1Mb4j1lACghUBU18OTXaSiibHOX00ULEVz pUYAnjGD6XJaCsqsUMy9j31FqDz2Y6Y2 =sSkP -----END PGP SIGNATURE----- --V2tfspbppmK1TQo2--