From owner-svn-ports-all@FreeBSD.ORG Tue Feb 3 00:11:22 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D700A2DF; Tue, 3 Feb 2015 00:11:22 +0000 (UTC) Received: from mail-pa0-x232.google.com (mail-pa0-x232.google.com [IPv6:2607:f8b0:400e:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A1695AAC; Tue, 3 Feb 2015 00:11:22 +0000 (UTC) Received: by mail-pa0-f50.google.com with SMTP id rd3so88609431pab.9; Mon, 02 Feb 2015 16:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=RF8OKL2axpYgGKAfqtfhmOEpMSl8w2ynVVAyv7Tw5fQ=; b=GhcpCmmUSYKNpNrDaM1MP4CGe3UjH1AuQNWX1w+mRDH0qL0L8ZtM/qDOL8QB568b83 wkCzETdxX8FByYqtJoWE8hQowBggRGPaWSO0s0KTTboJsevvvzBoEx6+6yWZZMFwTkNN lLNymjqrua4zjzryVEfmy48GpDd53cBmH6DYXAt+btpgaLKuBsEC1tXw7qo3EMZk3h9z coDKD0jDPJErQ8DGRfGHD4jcDcw1w88SCdYXraWSyXYmv0DR9zwqaDnT1DeS7Rf/2MCP OPfrwdZmcM/WCKu/UNRATlNj0GBwvKha7MjY+b5n+jiHxqbzBvaNerilHgFH3cw+xMBM /bjg== X-Received: by 10.68.112.194 with SMTP id is2mr32979899pbb.161.1422922282241; Mon, 02 Feb 2015 16:11:22 -0800 (PST) Received: from [192.168.1.107] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id rh11sm198876pdb.66.2015.02.02.16.11.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Feb 2015 16:11:21 -0800 (PST) Sender: Kubilay Kocak Message-ID: <54D01223.7020703@FreeBSD.org> Date: Tue, 03 Feb 2015 11:11:15 +1100 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Thunderbird/34.0 MIME-Version: 1.0 To: John Marino , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r378316 - head/devel/libhtp References: <201502021841.t12IfvP1021156@svn.freebsd.org> In-Reply-To: <201502021841.t12IfvP1021156@svn.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 00:11:23 -0000 On 3/02/2015 5:41 AM, John Marino wrote: > Author: marino > Date: Mon Feb 2 18:41:56 2015 > New Revision: 378316 > URL: https://svnweb.freebsd.org/changeset/ports/378316 > QAT: https://qat.redports.org/buildarchive/r378316/ > > Log: > devel/libhtp: tweak recent iconv:translit change to fix on some compilers > > When USES=iconv is changed to USES=iconv:translit, it can add libiconv > dependency from ports along with the addition of -liconv to LDFLAGS. > Most compilers (with FreeBSD's base compilers being notable exceptions) > will not look in /usr/local/lib by default, so this adds a -L argument > to LDFLAGS to help the linker find libiconv.so and unbreak the port on > affected platforms. > > Modified: > head/devel/libhtp/Makefile > > Modified: head/devel/libhtp/Makefile > ============================================================================== > --- head/devel/libhtp/Makefile Mon Feb 2 18:39:38 2015 (r378315) > +++ head/devel/libhtp/Makefile Mon Feb 2 18:41:56 2015 (r378316) > @@ -20,6 +20,7 @@ USE_LDCONFIG= yes > GNU_CONFIGURE= yes > CONFIGURE_ARGS= ${ICONV_CONFIGURE_ARG} > MAKE_ARGS= LIBS="-lz ${ICONV_LIB}" > +LDFLAGS+= -L${LOCALBASE}/lib > > PATHFIX_MAKEFILEIN= Makefile.am > > Apart from the lack of an Approved by: line for this commit, even in the case of blanket, isn't LIBS= better here? Further, if it is indeed the case that iconv:translit adds -liconv to LDFLAGS, wouldn't adding -L${LOCALBASE}/lib to LDFLAGS be better solved in Uses/iconv.mk when that case is true? Give me a holler on IRC or email in future if you notice anything up with ports I maintain. I'm almost always happy to oblige. ./koobs