From owner-dev-commits-src-main@freebsd.org Sat May 15 21:31:05 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EE443628931; Sat, 15 May 2021 21:31:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FjJVK4rdjz3wGw; Sat, 15 May 2021 21:31:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 14FLUsfc066663 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 16 May 2021 00:30:57 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 14FLUsfc066663 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 14FLUsFM066662; Sun, 16 May 2021 00:30:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 16 May 2021 00:30:54 +0300 From: Konstantin Belousov To: Lutz Donnerhacke Cc: Lutz Donnerhacke , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup Message-ID: References: <202105150701.14F717lf084359@gitrepo.freebsd.org> <20210515195812.GB17734@belenus.iks-jena.de> <20210515205133.GA19770@belenus.iks-jena.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210515205133.GA19770@belenus.iks-jena.de> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4FjJVK4rdjz3wGw X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 May 2021 21:31:06 -0000 On Sat, May 15, 2021 at 10:51:33PM +0200, Lutz Donnerhacke wrote: > On Sat, May 15, 2021 at 11:14:31PM +0300, Konstantin Belousov wrote: > > On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote: > > > Of course it was a style commit. > > > > > > + /* > > > + De-alias incoming echo and timestamp replies. > > > + Alias incoming echo and timestamp requests. > > > + */ > > > static int > > > IcmpAliasIn1(struct libalias *la, struct ip *pip) > > > { > > > - > > > LIBALIAS_LOCK_ASSERT(la); > > > - /* > > > - De-alias incoming echo and timestamp replies. > > > - Alias incoming echo and timestamp requests. > > > - */ > > > struct alias_link *lnk; > > > > I do not understand what are you trying to say. > > The diff above is a reformatting of the original diff in the commit. > It does show, what really happend during the edit: > - The empty line at the beginnen of the function body was removed This is optional, empty line at the beginning for the functions without local declarations was required before, and is allowed right now. > - The comment at the beginning of the function body was moved > before the function definition. > > The LIBALIAS_LOCK_ASSERT and the variable declarations were not moved. So you changed some style, but left the large violation in place.