From owner-freebsd-bugs@FreeBSD.ORG Mon Jan 9 22:00:27 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E077F106566C for ; Mon, 9 Jan 2012 22:00:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B93858FC13 for ; Mon, 9 Jan 2012 22:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q09M0QBf047054 for ; Mon, 9 Jan 2012 22:00:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q09M0QTj047053; Mon, 9 Jan 2012 22:00:26 GMT (envelope-from gnats) Resent-Date: Mon, 9 Jan 2012 22:00:26 GMT Resent-Message-Id: <201201092200.q09M0QTj047053@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Krüger Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CC1C106564A for ; Mon, 9 Jan 2012 21:59:34 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 2E7388FC08 for ; Mon, 9 Jan 2012 21:59:34 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q09LxXIV049249 for ; Mon, 9 Jan 2012 21:59:33 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q09LxXfA049248; Mon, 9 Jan 2012 21:59:33 GMT (envelope-from nobody) Message-Id: <201201092159.q09LxXfA049248@red.freebsd.org> Date: Mon, 9 Jan 2012 21:59:33 GMT From: Stefan Krüger To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/163974: Via RNG not enabled on amd64 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 22:00:27 -0000 >Number: 163974 >Category: kern >Synopsis: Via RNG not enabled on amd64 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jan 09 22:00:26 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Stefan Krüger >Release: FreeBSD 9.0-REL >Organization: >Environment: FreeBSD fbsd9.some.lan 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 9 21:46:25 UTC 2012 root@fbsd9.some.lan:/usr/obj/usr/src/sys/NANO amd64 >Description: The random kernel module on FreeBSD/amd64 doesn't support 64bit VIA CPUs hardware rng because the conf/Makefile/c files still assume Via CPUs are 32bit only. >How-To-Repeat: Boot FreeBSD/amd64 on a 64bit Via Nano CPU and notice that the hw rng is not used. >Fix: Patch attached with submission follows: --- conf/files.amd64.orig 2012-01-09 22:08:51.000000000 +0100 +++ conf/files.amd64 2012-01-09 22:10:23.000000000 +0100 @@ -208,6 +208,7 @@ dev/nfe/if_nfe.c optional nfe pci dev/nve/if_nve.c optional nve pci dev/nvram/nvram.c optional nvram isa +dev/random/nehemiah.c optional random dev/qlxgb/qla_dbg.c optional qlxgb pci dev/qlxgb/qla_hw.c optional qlxgb pci dev/qlxgb/qla_ioctl.c optional qlxgb pci --- modules/random/Makefile.orig 2012-01-09 22:07:22.000000000 +0100 +++ modules/random/Makefile 2012-01-09 22:07:27.000000000 +0100 @@ -6,7 +6,7 @@ KMOD= random SRCS= randomdev.c probe.c -.if ${MACHINE} == "i386" +.if ${MACHINE} == "i386" || ${MACHINE} == "amd64" SRCS+= nehemiah.c .endif SRCS+= randomdev_soft.c yarrow.c hash.c --- dev/random/probe.c.orig 2012-01-09 21:55:26.000000000 +0100 +++ dev/random/probe.c 2012-01-09 21:55:43.000000000 +0100 @@ -36,7 +36,7 @@ #include #include -#if defined(__i386__) && !defined(PC98) +#if defined(__amd64__) || (defined(__i386__) && !defined(PC98)) #include #include #include @@ -55,7 +55,7 @@ *systat = random_yarrow; /* Then go looking for hardware */ -#if defined(__i386__) && !defined(PC98) +#if defined(__amd64__) || (defined(__i386__) && !defined(PC98)) if (via_feature_rng & VIA_HAS_RNG) { *systat = random_nehemiah; } >Release-Note: >Audit-Trail: >Unformatted: