From nobody Tue Feb 10 17:07:16 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9SfY0vwvz6RdYl for ; Tue, 10 Feb 2026 17:07:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9SfY0MkJz3YKy for ; Tue, 10 Feb 2026 17:07:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770743237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3UeyIZaj7Ut/lcqI69/u7NlCeH15457l6zlvxK6v+rQ=; b=LXyEVZOYdrvZwExlFw763EQmLTW+JN5BU/V6LLTDk/ClQSyCQj1cpqgQh25nqFi85zeDLa VF/kRo0YnDmlaD7cj2ZOztRbd2bgade36QnxOJaDoJT27JdxcEiYKjVxYuELgfvUrG2lV0 X7Ou6gaIb7zy8zFDB5I6lnLSL5gXdz4K+tivc6K1jjP+jP3X1sYi84nMqRnnFFX/h1dGep 0R1niRXGVDVNN7MZZB6r9ctoOiMDDM+s0SZ7ZOcuK7b1rS13/G2VrxeInmC0tAOcm7o7UP hsP+SbtBmvwekK7+CvahvOAUQZWyvMe0XDthFVBBzCov/bDF+SOByIsQF5EAUg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770743237; a=rsa-sha256; cv=none; b=a9LwBb3nVgBicco8c2t2uGyYxnmA16KWhVq4xQYYJf/KmZUv8TB1QJ0y7ssuejCU2RB2qs dGyRvAoubH5RiAU8wJUu2X2KGO+Ve8LrZ6YOLbm3TQapt0k2VjlJkKc3HkuaSRyzFuJvyZ ryhRJeZ42hWyhP+5MloaD9waLNMmbhNk/iUT2++Ft1nwdg4O1dUogCzNWdMeYsjbdNqoVm 1zn89rv1b34piTwyZhObAYGmdB+Yvfwl5KBxt6KxDu75qobmUo9GWPIc2Wtf6uV7QZpD2h +VJZd+UgNpvWWvkpH75zUcZeFMDT+VcM+KgBRHJErsouJCeMyNJRpRZ2c8IHvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770743237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3UeyIZaj7Ut/lcqI69/u7NlCeH15457l6zlvxK6v+rQ=; b=F2cxBNLE4gCxEjL/cXzmXo9rgpyr8bnHdrGmJhG6wA/93J4sLSLBgi1+JhgBMFzLSGxS8c CYNII5QfgIJvlj23PBhNglezjEDwdsL09ELWTa1c5XH+27g+tRq63/Vg6RsvC+LdDQbr2p dFFxGecgeOq/a4jTsRjdKaja+ldhH42U+ijYy4IHzMNig0W+mZF/jE/Ky3InPDQhSL2ZUR yrF64WH4ubI/SNWCAOh9EyMxn58Yfz4WJ5vBfEa9eLbmb0RW7x7xbkVdd84u8MgSHwKyT2 cn+HpAAfwYk/7wo0uRhMxfAfvaV0u2vOli56L55bbeatjDqURaYjfQIK3btwWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9SfX6xCWz1R79 for ; Tue, 10 Feb 2026 17:07:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2198b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Feb 2026 17:07:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: 1ea0721e1a56 - main - vtgpu: Support virtio gpu on Parallels Desktop List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1ea0721e1a566fdb552b0a919c22667844a894d9 Auto-Submitted: auto-generated Date: Tue, 10 Feb 2026 17:07:16 +0000 Message-Id: <698b65c4.2198b.4fc2ec98@gitrepo.freebsd.org> The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=1ea0721e1a566fdb552b0a919c22667844a894d9 commit 1ea0721e1a566fdb552b0a919c22667844a894d9 Author: Andrew Turner AuthorDate: 2026-02-10 17:06:31 +0000 Commit: Andrew Turner CommitDate: 2026-02-10 17:06:31 +0000 vtgpu: Support virtio gpu on Parallels Desktop The Parallels Desktop Virtio GPU implementation doesn't handle enqueuing the VIRTIO_GPU_CMD_RESOURCE_ATTACH_BACKING request and memory list together. Work around this by splitting them before sending them to be enqueued. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D55147 --- sys/dev/virtio/gpu/virtio_gpu.c | 51 ++++++++++++++++++++++++++++++----------- 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/sys/dev/virtio/gpu/virtio_gpu.c b/sys/dev/virtio/gpu/virtio_gpu.c index 668eb170304a..b95bae9fe286 100644 --- a/sys/dev/virtio/gpu/virtio_gpu.c +++ b/sys/dev/virtio/gpu/virtio_gpu.c @@ -445,21 +445,33 @@ vtgpu_alloc_virtqueue(struct vtgpu_softc *sc) } static int -vtgpu_req_resp(struct vtgpu_softc *sc, void *req, size_t reqlen, - void *resp, size_t resplen) +vtgpu_req_resp2(struct vtgpu_softc *sc, void *req1, size_t req1len, + void *req2, size_t req2len, void *resp, size_t resplen) { struct sglist sg; - struct sglist_seg segs[2]; - int error; + struct sglist_seg segs[3]; + int error, rcount; - sglist_init(&sg, 2, segs); + sglist_init(&sg, 3, segs); - error = sglist_append(&sg, req, reqlen); + rcount = 1; + error = sglist_append(&sg, req1, req1len); if (error != 0) { device_printf(sc->vtgpu_dev, - "Unable to append the request to the sglist: %d\n", error); + "Unable to append the request to the sglist: %d\n", + error); return (error); } + if (req2 != NULL) { + error = sglist_append(&sg, req2, req2len); + if (error != 0) { + device_printf(sc->vtgpu_dev, + "Unable to append the request to the sglist: %d\n", + error); + return (error); + } + rcount++; + } error = sglist_append(&sg, resp, resplen); if (error != 0) { device_printf(sc->vtgpu_dev, @@ -467,7 +479,7 @@ vtgpu_req_resp(struct vtgpu_softc *sc, void *req, size_t reqlen, error); return (error); } - error = virtqueue_enqueue(sc->vtgpu_ctrl_vq, resp, &sg, 1, 1); + error = virtqueue_enqueue(sc->vtgpu_ctrl_vq, resp, &sg, rcount, 1); if (error != 0) { device_printf(sc->vtgpu_dev, "Enqueue failed: %d\n", error); return (error); @@ -479,6 +491,13 @@ vtgpu_req_resp(struct vtgpu_softc *sc, void *req, size_t reqlen, return (0); } +static int +vtgpu_req_resp(struct vtgpu_softc *sc, void *req, size_t reqlen, + void *resp, size_t resplen) +{ + return (vtgpu_req_resp2(sc, req, reqlen, NULL, 0, resp, resplen)); +} + static int vtgpu_get_display_info(struct vtgpu_softc *sc) { @@ -559,9 +578,15 @@ static int vtgpu_attach_backing(struct vtgpu_softc *sc) { struct { + /* + * Split the backing and mem request arguments as some + * hypervisors, e.g. Parallels Desktop, don't work when + * they are enqueued together. + */ struct { struct virtio_gpu_resource_attach_backing backing; - struct virtio_gpu_mem_entry mem[1]; + char pad; + struct virtio_gpu_mem_entry mem; } req; char pad; struct virtio_gpu_ctrl_hdr resp; @@ -577,11 +602,11 @@ vtgpu_attach_backing(struct vtgpu_softc *sc) s.req.backing.resource_id = htole32(VTGPU_RESOURCE_ID); s.req.backing.nr_entries = htole32(1); - s.req.mem[0].addr = htole64(sc->vtgpu_fb_info.fb_pbase); - s.req.mem[0].length = htole32(sc->vtgpu_fb_info.fb_size); + s.req.mem.addr = htole64(sc->vtgpu_fb_info.fb_pbase); + s.req.mem.length = htole32(sc->vtgpu_fb_info.fb_size); - error = vtgpu_req_resp(sc, &s.req, sizeof(s.req), &s.resp, - sizeof(s.resp)); + error = vtgpu_req_resp2(sc, &s.req.backing, sizeof(s.req.backing), + &s.req.mem, sizeof(s.req.mem), &s.resp, sizeof(s.resp)); if (error != 0) return (error);