From owner-cvs-all Tue Sep 10 12: 0: 7 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8AFDF37B400; Tue, 10 Sep 2002 12:00:03 -0700 (PDT) Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCF7E43E3B; Tue, 10 Sep 2002 12:00:02 -0700 (PDT) (envelope-from archie@dellroad.org) Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id LAA61301; Tue, 10 Sep 2002 11:57:39 -0700 (PDT) Received: (from archie@localhost) by arch20m.dellroad.org (8.11.6/8.11.6) id g8AItuf34207; Tue, 10 Sep 2002 11:55:56 -0700 (PDT) (envelope-from archie) From: Archie Cobbs Message-Id: <200209101855.g8AItuf34207@arch20m.dellroad.org> Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/ufs/ufs ufs_vnops.c In-Reply-To: <20020910133552.GD86704@phoenix.dmnstech.net> "from Eivind Eklund at Sep 10, 2002 03:35:52 pm" To: Eivind Eklund Date: Tue, 10 Sep 2002 11:55:56 -0700 (PDT) Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL88 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Eivind Eklund writes: > > > This seems to be wrong semantics to me - as far as I can tell, you've just > > > made the mv in the following case pass through without any change: > > > touch a > > > ln a b > > > mv a b > > > ... which would normally result in you just having the link 'b' to the file > > > originally named 'a', but you are silently leaving 'a' and 'b'. > > > > Yes, POSIX seems to require leaving 'a' alone here. I used essentially this > > to test recent changes. > > I looked the SUSv3 wording (which should be the same), and found it somewhat > unclear. I believe the intent is to refer to 'file' as in 'directory entry' > (after resolution of symbolic links). The sentence in question ("If the old > argument and the new argument resolve to the same existing file, rename() > shall return successfully and perform no other action.") is in the section > discussing symbolic links, and I believe that to be what it refers to. > > The new behaviour is IMO in violation of POLA, while the behaviour described I agree completely... it offends my sense of POLA to have 'mv a b' not remove the directory entry for 'a', even if 'a' and 'b' are hardlinked. -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message