From owner-svn-src-projects@FreeBSD.ORG  Sat May 14 23:20:14 2011
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A2560106566B;
	Sat, 14 May 2011 23:20:14 +0000 (UTC)
	(envelope-from marius@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 925CD8FC0A;
	Sat, 14 May 2011 23:20:14 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p4ENKE5E019158;
	Sat, 14 May 2011 23:20:14 GMT (envelope-from marius@svn.freebsd.org)
Received: (from marius@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id p4ENKEFB019156;
	Sat, 14 May 2011 23:20:14 GMT (envelope-from marius@svn.freebsd.org)
Message-Id: <201105142320.p4ENKEFB019156@svn.freebsd.org>
From: Marius Strobl <marius@FreeBSD.org>
Date: Sat, 14 May 2011 23:20:14 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-projects@freebsd.org
X-SVN-Group: projects
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r221932 - projects/largeSMP/sys/sparc64/sparc64
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 May 2011 23:20:14 -0000

Author: marius
Date: Sat May 14 23:20:14 2011
New Revision: 221932
URL: http://svn.freebsd.org/changeset/base/221932

Log:
  Fix yet another inversion in the logic by applying the x86 version of this,
  which avoids CPU_EMPTY() in the first place.
  Do I get a beer or something for every inversion I find?

Modified:
  projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c

Modified: projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c
==============================================================================
--- projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c	Sat May 14 22:15:38 2011	(r221931)
+++ projects/largeSMP/sys/sparc64/sparc64/mp_machdep.c	Sat May 14 23:20:14 2011	(r221932)
@@ -573,8 +573,8 @@ spitfire_ipi_selected(cpuset_t cpus, u_l
 {
 	u_int cpu;
 
-	while (CPU_EMPTY(&cpus)) {
-		cpu = cpusetobj_ffs(&cpus) - 1;
+	while ((cpu = cpusetobj_ffs(&cpus)) != 0) {
+		cpu--;
 		CPU_CLR(cpu, &cpus);
 		spitfire_ipi_single(cpu, d0, d1, d2);
 	}