From owner-freebsd-current@FreeBSD.ORG Fri Nov 3 22:14:51 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B32BC16A407 for ; Fri, 3 Nov 2006 22:14:51 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.FreeBSD.org (Postfix) with SMTP id 6FEF243D9B for ; Fri, 3 Nov 2006 22:14:42 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 22796 invoked by uid 399); 3 Nov 2006 22:14:39 -0000 Received: from localhost (HELO ?156.154.4.134?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 3 Nov 2006 22:14:39 -0000 Message-ID: <454BBF4C.3040205@FreeBSD.org> Date: Fri, 03 Nov 2006 14:14:36 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: freebsd-current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Warner Losh Subject: Re: Panic w/latest sources X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2006 22:14:51 -0000 > I have up to the minute -current sources, running on an Intel core > 2 duo in i386+SMP. Right after probing the PCI bus (pci0: > on pcib0) I get a panic. rman_get_start+0x6: movl 0(%eax),%eax > > GENERIC kernel from the October snapshot works fine. I'm afraid Warner is on the hook for this one. Reverting this change allows me to boot a new kernel with otherwise up to date sources. Warner, let me know if there is anything I can do to help, test, etc. Doug -------- Original Message -------- Subject: cvs commit: src/sys/dev/pci pci.c pci_pci.c pcivar.h Date: Mon, 30 Oct 2006 19:18:46 +0000 (UTC) From: Warner Losh To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org imp 2006-10-30 19:18:46 UTC FreeBSD src repository Modified files: sys/dev/pci pci.c pci_pci.c pcivar.h Log: More fully support 64-bit bars. Prior to this commit, we supported only those bars that had addresses assigned by the BIOS and where the bridges were properly programmed. Now even unprogrammed ones work. This was needed for sun4v. We still only implement up to 2GB memory ranges, even for 64-bit bars. PCI standards at least through 2.2 say that this is the max (or 1GB is, I only know it is < 32bits). o Always define pci_addr_t as uint64_t. A pci address is always 64-bits, but some hosts can't address all of them. o Preserve the upper half of the 64-bit word during resource probing. o Test to make sure that 64-bit values can fit in a u_long (true on some platforms, but not others). Don't use those that can't. o minor pedantry about data sizes. o Better bridge resource reporting in bootverbose case. o Minor formatting changes to cope with different data types on different platforms. Submitted by: jmg, with many changes by me to fully support 64-bit addresses. Revision Changes Path 1.317 +29 -12 src/sys/dev/pci/pci.c 1.42 +39 -33 src/sys/dev/pci/pci_pci.c 1.72 +1 -13 src/sys/dev/pci/pcivar.h http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pci.c.diff?&r1=1.316&r2=1.317&f=h http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pci_pci.c.diff?&r1=1.41&r2=1.42&f=h http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/dev/pci/pcivar.h.diff?&r1=1.71&r2=1.72&f=h -- This .signature sanitized for your protection