From owner-freebsd-current@freebsd.org Sun Jan 10 08:30:02 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC909A69302 for ; Sun, 10 Jan 2016 08:30:02 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 825E41C60 for ; Sun, 10 Jan 2016 08:30:02 +0000 (UTC) (envelope-from ohartman@zedat.fu-berlin.de) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.85) for freebsd-current@freebsd.org with esmtp (envelope-from ) id <1aIBNv-0039ag-82>; Sun, 10 Jan 2016 09:29:59 +0100 Received: from x55b3aac5.dyn.telefonica.de ([85.179.170.197] helo=thor.walstatt.dynvpn.de) by inpost2.zedat.fu-berlin.de (Exim 4.85) for freebsd-current@freebsd.org with esmtpsa (envelope-from ) id <1aIBNu-000X92-V1>; Sun, 10 Jan 2016 09:29:59 +0100 Date: Sun, 10 Jan 2016 09:29:54 +0100 From: "O. Hartmann" To: FreeBSD CURRENT Subject: [r293629]: ip_fw_table_algo.c:3818:6: error: variable 'error' is used uninitialized whenever 'if' condition is false Message-ID: <20160110092954.687fe472.ohartman@zedat.fu-berlin.de> Organization: FU Berlin X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/XIGiHfNS0sNLzcQFXXnbP2e"; protocol="application/pgp-signature" X-Originating-IP: 85.179.170.197 X-ZEDAT-Hint: A X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jan 2016 08:30:02 -0000 --Sig_/XIGiHfNS0sNLzcQFXXnbP2e Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Kernel build fails with the error shown below: [...] --- all_subdir_ipfw --- /usr/src/sys/modules/ipfw/../../netpfil/ipfw/ip_fw_table_algo.c:3818:6: err= or: variable 'error' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (keylen =3D=3D 4) { ^~~~~~~~~~~ /usr/src/sys/modules/ipfw/../../netpfil/ipfw/ip_fw_table_algo.c:3833:6: not= e: uninitialized use occurs here if (error !=3D 0) ^~~~~ /usr/src/sys/modules/ipfw/../../netpfil/ipfw/ip_fw_table_algo.c:3818:2: not= e: remove the 'if' if its condition is always true if (keylen =3D=3D 4) { ^~~~~~~~~~~~~~~~~ /usr/src/sys/modules/ipfw/../../netpfil/ipfw/ip_fw_table_algo.c:3815:11: no= te: initialize the variable 'error' to silence this warning int error; ^ =3D 0 1 error generated. *** [ip_fw_table_algo.o] Error code 1 make[4]: stopped in /usr/src/sys/modules/ipfw 1 error make[4]: stopped in /usr/src/sys/modules/ipfw *** [all_subdir_ipfw] Error code 2 [...] Kind regards, oh --Sig_/XIGiHfNS0sNLzcQFXXnbP2e Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWkhaCAAoJEOgBcD7A/5N8rbwH/1w7UkxdgZPPNs81abD1sg7z r5YmgDgYpmyZh/uKVOxQqdseptQu3mb9iYD/8o1Y7jlp+SqvlZO1n2vfmNtTgvFZ oHCumN8VMVwaW9jqtQAW44PiTEM/EgjQjqU5xfISR8gMZuKMsvQfoC5LmOOyd0pM Mh9CaZfdS7/hIDUXfFO4LW7vit8n5uA7t+Ag8yEgIBk4Fb6u7qp1F9kak5kJ6esY zLFGwUh/NmDKx7e1ZyZLd3PhdDwhXQy+Ndn7/ZArgQNdmeL0dIKDEnIxF9QKXEhC bf7lhMDoeiYfPRuTunOldURKWt6lbrySC7Iwmsb7JG1Q8IcSehUAEYECrgU0QKU= =0Rl1 -----END PGP SIGNATURE----- --Sig_/XIGiHfNS0sNLzcQFXXnbP2e--