From owner-freebsd-fs@FreeBSD.ORG Thu Feb 19 14:05:24 2015 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6EA13126 for ; Thu, 19 Feb 2015 14:05:24 +0000 (UTC) Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 01B71A2D for ; Thu, 19 Feb 2015 14:05:23 +0000 (UTC) Received: by mail-wg0-f49.google.com with SMTP id l18so7418380wgh.8 for ; Thu, 19 Feb 2015 06:05:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type; bh=NQ1ZnYUE8I7vNs7AGl50QdQhig3VceYC/i20QxQtSjk=; b=PEV6TxzlYIy9HyKsZSax064aC/MmpxKmM6VnefJiu1hCoEp9CHajEOh38p+pyVTqE3 Pm2ACEJKZPgy0l+ke5qANSPhIIgD8UQtEJ+3jrPVIc0OhDWMlA5tAtCwDuiLcQ0iNoGA XT49Qv86gYHebZAhQJoxpGwM/21Nm8MiWQFxIWxkc5xe93Iz/kN0bTwkQyg3rb87agMn lPCZTC6XxytPLxtdQQWy1Fd/wh8vl4oX+nXvn7XZfKCIgUKnCFhtmNx1QnwL7YGAsqJs B1cZsAcq0B6hwTPAA/PUfUxMDN4JQOmmF1k+bDd7O+2wFQnzRmpDdODpqZCtMhG1id4d qwxQ== X-Gm-Message-State: ALoCoQmIKGxYIvdUmBKuSzIfYko0rZssxxUxaJWmo5fz6Wkm83HizZvLxGNtoM1kDOMUbeYCjgDI X-Received: by 10.194.143.109 with SMTP id sd13mr9798535wjb.70.1424354721127; Thu, 19 Feb 2015 06:05:21 -0800 (PST) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id kj8sm37538176wjc.29.2015.02.19.06.05.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Feb 2015 06:05:20 -0800 (PST) Message-ID: <54E5ED9E.9010408@multiplay.co.uk> Date: Thu, 19 Feb 2015 14:05:18 +0000 From: Steven Hartland User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: freebsd-fs@freebsd.org Subject: Re: Creating zpool on NVMe Disks takes forever References: <54E5BB12.3060707@fuckner.net> <54E5CF6E.5030906@multiplay.co.uk> <54E5D574.8020406@fuckner.net> In-Reply-To: <54E5D574.8020406@fuckner.net> Content-Type: multipart/mixed; boundary="------------020602090107060600080905" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 14:05:24 -0000 This is a multi-part message in MIME format. --------------020602090107060600080905 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 19/02/2015 12:22, Michael Fuckner wrote: > On 02/19/2015 12:56 PM, Steven Hartland wrote: >> Disable trim on init: >> sysctl vfs.zfs.vdev.trim_on_init=0 > this fixed it, thx! > > but why does it take >8h to trim 2x 400GB? Or is trimming handled > differently on NVMe than on HDD/SSD? Its very basic but you might want to give the attached patch a go and see if it reduces you TRIM time significantly? Regards Steve --------------020602090107060600080905 Content-Type: text/x-patch; name="nvd-delmaxsize.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="nvd-delmaxsize.patch" Index: sys/dev/nvd/nvd.c =================================================================== --- sys/dev/nvd/nvd.c (revision 278999) +++ sys/dev/nvd/nvd.c (working copy) @@ -287,8 +287,10 @@ nvd_new_disk(struct nvme_namespace *ns, void *ctrl disk->d_flags = 0; - if (nvme_ns_get_flags(ns) & NVME_NS_DEALLOCATE_SUPPORTED) + if (nvme_ns_get_flags(ns) & NVME_NS_DEALLOCATE_SUPPORTED) { disk->d_flags |= DISKFLAG_CANDELETE; + disk->d_delmaxsize = ((off_t)disk->d_sectorsize * ((off_t)1 << 32)); + } if (nvme_ns_get_flags(ns) & NVME_NS_FLUSH_SUPPORTED) disk->d_flags |= DISKFLAG_CANFLUSHCACHE; --------------020602090107060600080905--