From owner-svn-src-head@FreeBSD.ORG  Wed Jun 10 23:46:25 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CA3C11A5;
 Wed, 10 Jun 2015 23:46:25 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 917AB19A5;
 Wed, 10 Jun 2015 23:46:24 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t5ANkK0I055645
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Thu, 11 Jun 2015 02:46:20 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t5ANkK5p055644;
 Thu, 11 Jun 2015 02:46:20 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Thu, 11 Jun 2015 02:46:20 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Eitan Adler <eadler@freebsd.org>
Cc: Mateusz Guzik <mjg@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r284211 - in head/sys: kern sys
Message-ID: <20150610234620.GS73119@FreeBSD.org>
References: <201506100934.t5A9YpoN093925@svn.freebsd.org>
 <20150610154445.GJ73119@FreeBSD.org>
 <CAF6rxgmHcmSoOUFr875s7NyzVCFVXc=BRLHPczP2jeTUU-jwsA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAF6rxgmHcmSoOUFr875s7NyzVCFVXc=BRLHPczP2jeTUU-jwsA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jun 2015 23:46:25 -0000

On Wed, Jun 10, 2015 at 02:54:36PM -0700, Eitan Adler wrote:
E> On 10 June 2015 at 08:44, Gleb Smirnoff <glebius@freebsd.org> wrote:
E> > On Wed, Jun 10, 2015 at 09:34:51AM +0000, Mateusz Guzik wrote:
E> > M>   This gets rid of fdesc_mtx.
E> > M>      int     fd_holdleaderscount;    /* block fdfree() for shared close() */
E> >
E> > Shouldn't they be volatile u_int?
E> 
E> why?

Since that's the type that refcount(9) works on.

-- 
Totus tuus, Glebius.