From owner-cvs-all@FreeBSD.ORG Thu Jan 10 01:25:35 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B377C16A420; Thu, 10 Jan 2008 01:25:35 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 4A40413C468; Thu, 10 Jan 2008 01:25:35 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id m0A1PVtV024603; Wed, 9 Jan 2008 18:25:31 -0700 (MST) (envelope-from scottl@samsco.org) Message-Id: <4598CC24-E3D2-496E-B1ED-D60117F4C9E2@samsco.org> From: Scott Long To: Attilio Rao In-Reply-To: <200801100110.m0A1AwBc099854@repoman.freebsd.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v915) Date: Wed, 9 Jan 2008 18:25:31 -0700 References: <200801100110.m0A1AwBc099854@repoman.freebsd.org> X-Mailer: Apple Mail (2.915) X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Wed, 09 Jan 2008 18:25:31 -0700 (MST) X-Spam-Status: No, score=-1.4 required=5.4 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/compat/linux linux_file.c linux_getcwd.c src/sys/compat/opensolaris/kern opensolaris_kobj.c opensolaris_vfs.c src/sys/compat/opensolaris/sys vnode.h src/sys/compat/pecoff imgact_pecoff.c src/sys/compat/svr4 ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2008 01:25:35 -0000 Am I reading your description right in that there will be multiple API changes coming? If so, are you going to do a single __FreeBSD_version bump for all of them, or a bump for each of them? Scott On Jan 9, 2008, at 6:10 PM, Attilio Rao wrote: > attilio 2008-01-10 01:10:58 UTC > > FreeBSD src repository > > Modified files: > sys/compat/linprocfs linprocfs.c > sys/compat/linux linux_file.c linux_getcwd.c > sys/compat/opensolaris/kern opensolaris_kobj.c > opensolaris_vfs.c > sys/compat/opensolaris/sys vnode.h > sys/compat/pecoff imgact_pecoff.c > sys/compat/svr4 imgact_svr4.c svr4_fcntl.c svr4_misc.c > sys/contrib/opensolaris/uts/common/fs gfs.c > sys/contrib/opensolaris/uts/common/fs/zfs zfs_ctldir.c > zfs_replay.c > zfs_vfsops.c > zfs_vnops.c > zfs_znode.c > sys/dev/hwpmc hwpmc_mod.c > sys/dev/md md.c > sys/fs/cd9660 cd9660_lookup.c cd9660_vfsops.c > sys/fs/coda coda_vfsops.c coda_vnops.c > sys/fs/devfs devfs_devs.c devfs_vnops.c > sys/fs/fdescfs fdesc_vfsops.c fdesc_vnops.c > sys/fs/fifofs fifo_vnops.c > sys/fs/hpfs hpfs_vnops.c > sys/fs/msdosfs msdosfs_lookup.c msdosfs_vfsops.c > msdosfs_vnops.c > sys/fs/ntfs ntfs_vfsops.c ntfs_vnops.c > sys/fs/nullfs null_subr.c null_vfsops.c > sys/fs/nwfs nwfs_node.c nwfs_vnops.c > sys/fs/portalfs portal_vfsops.c portal_vnops.c > sys/fs/procfs procfs.c procfs_map.c > sys/fs/pseudofs pseudofs_vncache.c pseudofs_vnops.c > sys/fs/smbfs smbfs_io.c smbfs_node.c smbfs_vnops.c > sys/fs/tmpfs tmpfs_subr.c tmpfs_vfsops.c tmpfs_vnops.c > sys/fs/udf udf_vnops.c > sys/fs/unionfs union_subr.c union_vfsops.c union_vnops.c > sys/gnu/fs/ext2fs ext2_lookup.c ext2_vfsops.c ext2_vnops.c > fs.h > sys/gnu/fs/reiserfs reiserfs_namei.c > sys/gnu/fs/xfs/FreeBSD xfs_freebsd_iget.c xfs_super.c > xfs_vnode.c xfs_vnops.c > sys/i386/ibcs2 ibcs2_misc.c imgact_coff.c > sys/i386/linux imgact_linux.c > sys/kern imgact_aout.c imgact_elf.c imgact_gzip.c > kern_alq.c kern_descrip.c kern_exec.c > kern_jail.c kern_ktrace.c kern_proc.c > kern_sig.c uipc_mqueue.c uipc_syscalls.c > vfs_acl.c vfs_aio.c vfs_bio.c vfs_cache.c > vfs_extattr.c vfs_lookup.c vfs_mount.c > vfs_subr.c vfs_syscalls.c vfs_vnops.c > sys/nfs4client nfs4_vnops.c > sys/nfsclient nfs_subs.c nfs_vnops.c > sys/nfsserver nfs_serv.c nfs_srvsubs.c > sys/security/audit audit_arg.c audit_bsm_klib.c > audit_worker.c > sys/security/mac mac_process.c mac_syscalls.c > sys/sys vnode.h > sys/ufs/ffs ffs_snapshot.c ffs_softdep.c ffs_vfsops.c > sys/ufs/ufs ufs_extattr.c ufs_lookup.c ufs_quota.c > ufs_vnops.c > sys/vm swap_pager.c vm_contig.c vm_object.c > vnode_pager.c > Log: > vn_lock() is currently only used with the 'curthread' passed as > argument. > Remove this argument and pass curthread directly to underlying > VOP_LOCK1() VFS method. This modify makes the code cleaner and in > particular remove an annoying dependence helping next lockmgr() > cleanup. > KPI results, obviously, changed. > > Manpage and FreeBSD_version will be updated through further commits. > > As a side note, would be valuable to say that next commits will > address > a similar cleanup about VFS methods, in particular vop_lock1 and > vop_unlock. > > Tested by: Diego Sardina , > Andrea Di Pasquale > > Revision Changes Path > 1.118 +1 -1 src/sys/compat/linprocfs/linprocfs.c > 1.108 +1 -1 src/sys/compat/linux/linux_file.c > 1.29 +2 -2 src/sys/compat/linux/linux_getcwd.c > 1.5 +3 -3 src/sys/compat/opensolaris/kern/ > opensolaris_kobj.c > 1.8 +3 -3 src/sys/compat/opensolaris/kern/ > opensolaris_vfs.c > 1.4 +2 -2 src/sys/compat/opensolaris/sys/vnode.h > 1.42 +1 -1 src/sys/compat/pecoff/imgact_pecoff.c > 1.27 +1 -1 src/sys/compat/svr4/imgact_svr4.c > 1.42 +1 -1 src/sys/compat/svr4/svr4_fcntl.c > 1.99 +3 -3 src/sys/compat/svr4/svr4_misc.c > 1.4 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/gfs.c > 1.6 +3 -3 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_ctldir.c > 1.4 +7 -7 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_replay.c > 1.13 +4 -4 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_vfsops.c > 1.25 +5 -5 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_vnops.c > 1.11 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_znode.c > 1.31 +1 -1 src/sys/dev/hwpmc/hwpmc_mod.c > 1.172 +6 -6 src/sys/dev/md/md.c > 1.44 +1 -1 src/sys/fs/cd9660/cd9660_lookup.c > 1.152 +2 -2 src/sys/fs/cd9660/cd9660_vfsops.c > 1.69 +3 -3 src/sys/fs/coda/coda_vfsops.c > 1.77 +2 -2 src/sys/fs/coda/coda_vnops.c > 1.52 +1 -1 src/sys/fs/devfs/devfs_devs.c > 1.154 +5 -5 src/sys/fs/devfs/devfs_vnops.c > 1.58 +1 -1 src/sys/fs/fdescfs/fdesc_vfsops.c > 1.105 +2 -2 src/sys/fs/fdescfs/fdesc_vnops.c > 1.141 +2 -2 src/sys/fs/fifofs/fifo_vnops.c > 1.71 +1 -1 src/sys/fs/hpfs/hpfs_vnops.c > 1.53 +1 -1 src/sys/fs/msdosfs/msdosfs_lookup.c > 1.184 +2 -2 src/sys/fs/msdosfs/msdosfs_vfsops.c > 1.182 +2 -2 src/sys/fs/msdosfs/msdosfs_vnops.c > 1.91 +1 -1 src/sys/fs/ntfs/ntfs_vfsops.c > 1.61 +1 -1 src/sys/fs/ntfs/ntfs_vnops.c > 1.53 +1 -1 src/sys/fs/nullfs/null_subr.c > 1.85 +2 -2 src/sys/fs/nullfs/null_vfsops.c > 1.40 +1 -1 src/sys/fs/nwfs/nwfs_node.c > 1.43 +1 -1 src/sys/fs/nwfs/nwfs_vnops.c > 1.62 +1 -1 src/sys/fs/portalfs/portal_vfsops.c > 1.74 +1 -2 src/sys/fs/portalfs/portal_vnops.c > 1.17 +1 -1 src/sys/fs/procfs/procfs.c > 1.41 +1 -1 src/sys/fs/procfs/procfs_map.c > 1.39 +1 -1 src/sys/fs/pseudofs/pseudofs_vncache.c > 1.66 +2 -2 src/sys/fs/pseudofs/pseudofs_vnops.c > 1.42 +2 -2 src/sys/fs/smbfs/smbfs_io.c > 1.35 +1 -1 src/sys/fs/smbfs/smbfs_node.c > 1.66 +1 -1 src/sys/fs/smbfs/smbfs_vnops.c > 1.15 +1 -1 src/sys/fs/tmpfs/tmpfs_subr.c > 1.16 +1 -1 src/sys/fs/tmpfs/tmpfs_vfsops.c > 1.14 +2 -2 src/sys/fs/tmpfs/tmpfs_vnops.c > 1.67 +1 -1 src/sys/fs/udf/udf_vnops.c > 1.97 +3 -3 src/sys/fs/unionfs/union_subr.c > 1.88 +3 -3 src/sys/fs/unionfs/union_vfsops.c > 1.151 +23 -22 src/sys/fs/unionfs/union_vnops.c > 1.53 +1 -1 src/sys/gnu/fs/ext2fs/ext2_lookup.c > 1.168 +3 -3 src/sys/gnu/fs/ext2fs/ext2_vfsops.c > 1.111 +3 -3 src/sys/gnu/fs/ext2fs/ext2_vnops.c > 1.19 +1 -1 src/sys/gnu/fs/ext2fs/fs.h > 1.5 +1 -1 src/sys/gnu/fs/reiserfs/reiserfs_namei.c > 1.3 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_freebsd_iget.c > 1.6 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_super.c > 1.3 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnode.c > 1.7 +6 -6 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnops.c > 1.69 +2 -2 src/sys/i386/ibcs2/ibcs2_misc.c > 1.69 +1 -1 src/sys/i386/ibcs2/imgact_coff.c > 1.57 +1 -1 src/sys/i386/linux/imgact_linux.c > 1.103 +2 -3 src/sys/kern/imgact_aout.c > 1.184 +2 -2 src/sys/kern/imgact_elf.c > 1.57 +1 -1 src/sys/kern/imgact_gzip.c > 1.21 +1 -1 src/sys/kern/kern_alq.c > 1.319 +2 -2 src/sys/kern/kern_descrip.c > 1.314 +4 -4 src/sys/kern/kern_exec.c > 1.73 +1 -1 src/sys/kern/kern_jail.c > 1.124 +1 -1 src/sys/kern/kern_ktrace.c > 1.260 +1 -2 src/sys/kern/kern_proc.c > 1.354 +1 -1 src/sys/kern/kern_sig.c > 1.28 +3 -4 src/sys/kern/uipc_mqueue.c > 1.262 +2 -2 src/sys/kern/uipc_syscalls.c > 1.55 +3 -3 src/sys/kern/vfs_acl.c > 1.235 +1 -1 src/sys/kern/vfs_aio.c > 1.533 +1 -1 src/sys/kern/vfs_bio.c > 1.116 +2 -2 src/sys/kern/vfs_cache.c > 1.433 +4 -4 src/sys/kern/vfs_extattr.c > 1.104 +12 -7 src/sys/kern/vfs_lookup.c > 1.271 +2 -2 src/sys/kern/vfs_mount.c > 1.714 +6 -6 src/sys/kern/vfs_subr.c > 1.447 +20 -20 src/sys/kern/vfs_syscalls.c > 1.257 +17 -16 src/sys/kern/vfs_vnops.c > 1.38 +2 -2 src/sys/nfs4client/nfs4_vnops.c > 1.148 +3 -3 src/sys/nfsclient/nfs_subs.c > 1.278 +2 -2 src/sys/nfsclient/nfs_vnops.c > 1.176 +13 -13 src/sys/nfsserver/nfs_serv.c > 1.151 +1 -1 src/sys/nfsserver/nfs_srvsubs.c > 1.16 +2 -2 src/sys/security/audit/audit_arg.c > 1.9 +1 -1 src/sys/security/audit/audit_bsm_klib.c > 1.18 +1 -1 src/sys/security/audit/audit_worker.c > 1.121 +2 -2 src/sys/security/mac/mac_process.c > 1.134 +2 -2 src/sys/security/mac/mac_syscalls.c > 1.328 +2 -2 src/sys/sys/vnode.h > 1.138 +6 -6 src/sys/ufs/ffs/ffs_snapshot.c > 1.215 +2 -2 src/sys/ufs/ffs/ffs_softdep.c > 1.332 +4 -4 src/sys/ufs/ffs/ffs_vfsops.c > 1.87 +5 -9 src/sys/ufs/ufs/ufs_extattr.c > 1.85 +3 -3 src/sys/ufs/ufs/ufs_lookup.c > 1.96 +4 -6 src/sys/ufs/ufs/ufs_quota.c > 1.294 +3 -3 src/sys/ufs/ufs/ufs_vnops.c > 1.299 +3 -3 src/sys/vm/swap_pager.c > 1.66 +1 -1 src/sys/vm/vm_contig.c > 1.389 +1 -1 src/sys/vm/vm_object.c > 1.239 +1 -1 src/sys/vm/vnode_pager.c