Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Aug 2013 14:32:03 +0200 (CEST)
From:      Guido Falsi <madpilot@FreeBSD.org>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/181615: [PATCH] audio/wavegain: Fix build with clang
Message-ID:  <3cQ5tW5Jkwz2pq@micro.madpilot.net>
Resent-Message-ID: <201308281240.r7SCe3w8095638@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         181615
>Category:       ports
>Synopsis:       [PATCH] audio/wavegain: Fix build with clang
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 28 12:40:03 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Guido Falsi
>Release:        FreeBSD 9.1-STABLE amd64
>Organization:
none
>Environment:
System: FreeBSD micro.madpilot.net 9.1-STABLE FreeBSD 9.1-STABLE #21 r252026: Thu Jun 20 16:27:06 CEST 2013 root@micro.madpilot.net:/usr/obj/usr/src/sys/MICRO amd64

>Description:

- Fix build with clang (Respect CC)
- Make it respect LOCALBASE
- Trim Makefile headers
- Convert  LIB_DEPENDS to new format and remove ABI version number
- USES=gmake

>How-To-Repeat:
>Fix:

Index: Makefile
===================================================================
--- Makefile	(revision 325515)
+++ Makefile	(working copy)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	wavegain
-# Date created:			24 May 2008
-# Whom:				Denise H. G. <darcsis@gmail.com>
-#
+# Created by: Denise H. G. <darcsis@gmail.com>
 # $FreeBSD$
-#
 
 PORTNAME=	wavegain
 PORTVERSION=	1.2.8
@@ -14,10 +10,10 @@
 MAINTAINER=	darcsis@gmail.com
 COMMENT=	A program that applies ReplayGain to wave files
 
-LIB_DEPENDS=	sndfile.1:${PORTSDIR}/audio/libsndfile
+LIB_DEPENDS=	libsndfile.so:${PORTSDIR}/audio/libsndfile
 
 USE_ZIP=	yes
-USE_GMAKE=	yes
+USES=		gmake
 USE_DOS2UNIX=	audio.c wavegain.c
 
 PLIST_FILES=	bin/wavegain
@@ -30,6 +26,9 @@
 BROKEN=		Does not compile on ia64, powerpc, or sparc64
 .endif
 
+post-patch:
+	@${REINPLACE_CMD} -e "s|%%LOCALBASE%%|${LOCALBASE}|" ${WRKSRC}/Makefile.linux
+
 do-configure:
 	@cd ${WRKSRC} && ${CP} Makefile.linux Makefile
 
Index: files/patch-Makefile.linux
===================================================================
--- files/patch-Makefile.linux	(revision 325515)
+++ files/patch-Makefile.linux	(working copy)
@@ -1,9 +1,11 @@
---- Makefile.linux	2005-11-30 11:17:14.000000000 +0800
-+++ Makefile.linux	2008-05-24 22:14:34.000000000 +0800
-@@ -1,5 +1,5 @@
+--- Makefile.linux.orig	2005-11-30 12:17:14.000000000 +0100
++++ Makefile.linux	2013-08-28 13:02:43.817494398 +0200
+@@ -1,5 +1,7 @@
++CC ?=	cc
++
  all:
 -	gcc *.c -o wavegain -DHAVE_CONFIG_H -lm -lsndfile
-+	gcc *.c -o wavegain -DHAVE_CONFIG_H -lm -lsndfile -L/usr/local/lib
++	${CC} *.c -o wavegain -DHAVE_CONFIG_H -lm -lsndfile -L%%LOCALBASE%%/lib
  
  install:
  	install -d /usr/bin/
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3cQ5tW5Jkwz2pq>