From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jan 31 00:20:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 780CE4AE for ; Thu, 31 Jan 2013 00:20:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 5D5FDEAF for ; Thu, 31 Jan 2013 00:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0V0K0oC083752 for ; Thu, 31 Jan 2013 00:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0V0K03U083751; Thu, 31 Jan 2013 00:20:00 GMT (envelope-from gnats) Resent-Date: Thu, 31 Jan 2013 00:20:00 GMT Resent-Message-Id: <201301310020.r0V0K03U083751@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 30E252EB for ; Thu, 31 Jan 2013 00:14:31 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15]) by mx1.freebsd.org (Postfix) with ESMTP id E44A4E83 for ; Thu, 31 Jan 2013 00:14:30 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1U0hnK-0007C6-Uh for FreeBSD-gnats-submit@freebsd.org; Thu, 31 Jan 2013 04:14:22 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 86573B84D for ; Thu, 31 Jan 2013 04:14:22 +0400 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 7BEAD7D6; Thu, 31 Jan 2013 04:14:22 +0400 (MSK) Message-Id: <20130131001422.7BEAD7D6@hades.panopticon> Date: Thu, 31 Jan 2013 04:14:22 +0400 (MSK) From: Dmitry Marakasov To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/175717: [Mk] do not require distinfo for for fetch-urlall-list X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Dmitry Marakasov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2013 00:20:00 -0000 >Number: 175717 >Category: ports >Synopsis: [Mk] do not require distinfo for for fetch-urlall-list >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jan 31 00:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 9.0-RELEASE-p3 amd64 >Organization: >Environment: System: FreeBSD hades.panopticon 9.0-RELEASE-p3 FreeBSD 9.0-RELEASE-p3 #0: Wed Jun 13 17:39:20 MSK 2012 root@hades.panopticon:/usr/obj/usr/src/sys/HADES amd64 >Description: make fetch-urlall-list won't work for a port without distinfo file: --- % make fetch-urlall-list /usr/bin/awk: can't open file /usr/ports/foo/bar/distinfo source line number 1 *** Error code 2 Stop in /usr/ports/foo/bar. *** Error code 1 Stop in /usr/ports/foo/bar. --- this, however, is quite useful when creating new ports, where distinfo is not yet generated, but you want to check fetch list or fetch a distfile by hand. Also, if an empty distinfo is created, fetch-urlall-list will work again correctly. The patch attached fixes this problem by removing commands results of which are not even used from fetch-url-list-int target. >How-To-Repeat: For a random port, remove distinfo and try to run make fetch-urlall-list >Fix: --- bsd.port.mk.patch begins here --- Index: bsd.port.mk =================================================================== --- bsd.port.mk (revision 311274) +++ bsd.port.mk (working copy) @@ -4741,8 +4741,6 @@ SORTED_MASTER_SITES_CMD_TMP="${SORTED_MASTER_SITES_DEFAULT_CMD}" ; \ fi ; \ for site in `eval $$SORTED_MASTER_SITES_CMD_TMP ${_RANDOMIZE_SITES}`; do \ - DIR=${DIST_SUBDIR:S/\//\\\\\//g:S/./\\\\./g:S/+/\\\\+/g:S/?/\\\\?/g}; \ - CKSIZE=`${AWK} "/^SIZE \($${DIR:+$$DIR\/}$$fileptn\)/"'{print $$4}' ${DISTINFO_FILE}`; \ case $${file} in \ */*) args="-o $${file} $${site}$${file}";; \ *) args=$${site}$${file};; \ @@ -4773,8 +4771,6 @@ SORTED_PATCH_SITES_CMD_TMP="${SORTED_PATCH_SITES_DEFAULT_CMD}" ; \ fi ; \ for site in `eval $$SORTED_PATCH_SITES_CMD_TMP ${_RANDOMIZE_SITES}`; do \ - DIR=${DIST_SUBDIR:S/\//\\\\\//g:S/./\\\\./g:S/+/\\\\+/g:S/?/\\\\?/g}; \ - CKSIZE=`${AWK} "/^SIZE \($${DIR:+$$DIR\/}$$fileptn\)/"'{print $$4}' ${DISTINFO_FILE}`; \ case $${file} in \ */*) args="-o $${file} $${site}$${file}";; \ *) args=$${site}$${file};; \ --- bsd.port.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: