From owner-p4-projects@FreeBSD.ORG  Mon Aug  4 14:09:44 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 765211065672; Mon,  4 Aug 2008 14:09:44 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3A573106566C
	for <perforce@freebsd.org>; Mon,  4 Aug 2008 14:09:44 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 2D6308FC14
	for <perforce@freebsd.org>; Mon,  4 Aug 2008 14:09:44 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m74E9iX2059955
	for <perforce@freebsd.org>; Mon, 4 Aug 2008 14:09:44 GMT
	(envelope-from trasz@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m74E9i2i059953
	for perforce@freebsd.org; Mon, 4 Aug 2008 14:09:44 GMT
	(envelope-from trasz@freebsd.org)
Date: Mon, 4 Aug 2008 14:09:44 GMT
Message-Id: <200808041409.m74E9i2i059953@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	trasz@freebsd.org using -f
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 146622 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Aug 2008 14:09:44 -0000

http://perforce.freebsd.org/chv.cgi?CH=146622

Change 146622 by trasz@trasz_traszkan on 2008/08/04 14:09:33

	If ls(1) cannot read ACL due to EACCES or EPERM, then there
	is obviously some ACL denying it.  Mark file with "+" in that
	case.

Affected files ...

.. //depot/projects/soc2008/trasz_nfs4acl/TODO#28 edit
.. //depot/projects/soc2008/trasz_nfs4acl/bin/ls/print.c#3 edit

Differences ...

==== //depot/projects/soc2008/trasz_nfs4acl/TODO#28 (text+ko) ====

@@ -2,9 +2,6 @@
 
 - Make setfacl(1) error messages more user friendly.
 
-- Correctly handle the situation in which we can stat, but cannot
-  read ACL, in ls(1).
-
 - Clean up #defines.  For example, make VREAD_NAMED_ATTRS equal
   to ACL_READ_NAMED_ATTRS, so there is no need for translation
   between the two in kern/subr_acl_nfs4.c.

==== //depot/projects/soc2008/trasz_nfs4acl/bin/ls/print.c#3 (text+ko) ====

@@ -666,6 +666,14 @@
 			buf[10] = '+';
 
 		acl_free(facl);
-	} else
+	} else {
+		/*
+		 * We were denied access.  So, obviously, there
+		 * is some ACL denying READ_ACL there.
+		 */
+		if (errno == EPERM || errno == EACCES)
+			buf[10] = '+';
+
 		warn("%s", name);
+	}
 }