From nobody Fri Sep 22 21:51:16 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RsmDh6qb1z4tTjy; Fri, 22 Sep 2023 21:51:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RsmDh6J2xz3Pr9; Fri, 22 Sep 2023 21:51:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695419476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i5ENA61nqNFt1D+BEwTjLDbQoWCxqZ+NQJJuuuikcMM=; b=bAGWcky0UgGtheux8YNLEQI54pwU2G8t3j+IU4sLt3y0iLrS7NUsPFcZBFMJsT9tnsu7ZR V7rkPOoCU3JTiW/q3V3+K2gwKBgPUssZetX5PvUIEYnqXvaNDeih33MD4bmjkCGNZCIL0x RL4Y3SCkgE9xwk82p5mkmDiN45K44+IfEX3Ll+FAXbsSMWPPurQ4DSqsrmYpnklufH73Zc RfTMkPDjaeiGAogKEfgZNQW4JXnOw6rOxhNxaSRnlAyVBKTcQWhQtjYWOPs3qbQBQFxG87 ftlZGKi/SSuRkPx4IczzUzJ6dGzA3X+anXyiC/LabBWsfbTGD4MvU1oeMzV9Kw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695419476; a=rsa-sha256; cv=none; b=s8wZDorDluF4U+3agphqumDf9oIcl0TVEG+obaAyeX1WC53Ocq7XxGHv1NkkkSKCKH3oHt NHHZZv+3nB8q5d4P4Xi+6dcS8WjOyuImfiT0+RMWDiCClCGpLfNpEcOk803+gm/7R2hjV5 +dDsgAI8YwI4w1SMka2ivSZEB3rZt+2xpdKBja92dV0vx0eTmKZGo7Hy/E2HQiac72+JJk hdFj92LgwPdafyFQgBZRuutEGVcTromCNY/HXPEAKM6jiCaAQNFwvljs0udW42vyzCxbAY pfxIWpX3TBkHz0MYrspwweaOEuYYPNnM4h+Hvs+JHyJt9cjhZ/VUAyEr7xE4hQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695419476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i5ENA61nqNFt1D+BEwTjLDbQoWCxqZ+NQJJuuuikcMM=; b=lMxiaHJuR1jXmWxQeOHpaz/yVFhLtuvZUBfh5dKRvCBoHLQ0r00zuE76qMWMydLEc5hLaj XUKDon5m9wlaTUDJWy43eJqx6zV0+B0Ums2D8AdO/SfPadn6fU7HI0ohI9pzqrHIaB+wci uvAR4vPSQA8C2gmHQelw5sO3fk2WvWIwx7mpBe8pwb+0F+FLc+M3GwUJERNkfmJxeol3Ie 9AH7g3ukVoKKunK/GwRFMoBaWe9EeELRhhZcbp5bmcFTYBCXCVtY7AlCMtCl3fXUuF9xBX ozB1LXANrCx1aEwSUaKwZqCGiuUDoJ5ooqc1QD5T2U5heEA5iydKpMSTyzpa6A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RsmDh5C6JzfBL; Fri, 22 Sep 2023 21:51:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38MLpGES039310; Fri, 22 Sep 2023 21:51:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38MLpG0q039307; Fri, 22 Sep 2023 21:51:16 GMT (envelope-from git) Date: Fri, 22 Sep 2023 21:51:16 GMT Message-Id: <202309222151.38MLpG0q039307@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 210dd7aa1f48 - stable/14 - vfs: fix stale comment about freevnodes management List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 210dd7aa1f48848707b09a172a957f0f4b7aacab Auto-Submitted: auto-generated The branch stable/14 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=210dd7aa1f48848707b09a172a957f0f4b7aacab commit 210dd7aa1f48848707b09a172a957f0f4b7aacab Author: Mateusz Guzik AuthorDate: 2023-09-14 17:28:32 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-22 21:50:47 +0000 vfs: fix stale comment about freevnodes management (cherry picked from commit 9dc0c983b0931f359c2ff10d47ad835ef74e929a) --- sys/kern/vfs_subr.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 4c9cb6200f10..ed478d33aed0 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -1444,12 +1444,12 @@ static struct proc *vnlruproc; static int vnlruproc_sig; /* - * The main freevnodes counter is only updated when threads requeue their vnode - * batches. CPUs are conditionally walked to compute a more accurate total. + * The main freevnodes counter is only updated when a counter local to CPU + * diverges from 0 by more than VNLRU_FREEVNODES_SLOP. CPUs are conditionally + * walked to compute a more accurate total. * - * Limit how much of a slop are we willing to tolerate. Note: the actual value - * at any given moment can still exceed slop, but it should not be by significant - * margin in practice. + * Note: the actual value at any given moment can still exceed slop, but it + * should not be by significant margin in practice. */ #define VNLRU_FREEVNODES_SLOP 126