From owner-freebsd-bugs@FreeBSD.ORG Fri Jul 20 17:30:01 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C13BF16A41F for ; Fri, 20 Jul 2007 17:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9C8D813C4B4 for ; Fri, 20 Jul 2007 17:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l6KHU1GE008674 for ; Fri, 20 Jul 2007 17:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l6KHU1OF008673; Fri, 20 Jul 2007 17:30:01 GMT (envelope-from gnats) Resent-Date: Fri, 20 Jul 2007 17:30:01 GMT Resent-Message-Id: <200707201730.l6KHU1OF008673@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eugene Grosbein Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E0B816A419 for ; Fri, 20 Jul 2007 17:25:10 +0000 (UTC) (envelope-from eugen@grosbein.pp.ru) Received: from grosbein.pp.ru (grgw.svzserv.kemerovo.su [213.184.64.166]) by mx1.freebsd.org (Postfix) with ESMTP id 92B7813C467 for ; Fri, 20 Jul 2007 17:25:09 +0000 (UTC) (envelope-from eugen@grosbein.pp.ru) Received: from grosbein.pp.ru (localhost [127.0.0.1]) by grosbein.pp.ru (8.14.1/8.14.1) with ESMTP id l6KHP7MP001921; Sat, 21 Jul 2007 01:25:07 +0800 (KRAST) (envelope-from eugen@grosbein.pp.ru) Received: (from eugen@localhost) by grosbein.pp.ru (8.14.1/8.14.1/Submit) id l6KHP73U001920; Sat, 21 Jul 2007 01:25:07 +0800 (KRAST) (envelope-from eugen) Message-Id: <200707201725.l6KHP73U001920@grosbein.pp.ru> Date: Sat, 21 Jul 2007 01:25:07 +0800 (KRAST) From: Eugene Grosbein To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: rodrigc@FreeBSD.org Subject: kern/114776: [patch] "mount_msdosfs -l" does not work due to bad MFC X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eugene Grosbein List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2007 17:30:01 -0000 >Number: 114776 >Category: kern >Synopsis: [patch] "mount_msdosfs -l" does not work due to bad MFC >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jul 20 17:30:01 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Eugene Grosbein >Release: FreeBSD 6.2-STABLE i386 >Organization: Svyaz-Service JSC >Environment: System: FreeBSD grosbein.pp.ru 6.2-STABLE FreeBSD 6.2-STABLE #9: Sat Jul 21 00:30:50 KRAST 2007 eu@grosbein.pp.ru:/usr/obj/usr/local/src/sys/DADV i386 >Description: It's impossible to force using/generating long file names for FAT filesystem when its root directory does not have one such name. This bug was fixed in CURRENT in October 2005, sys/fs/msdosfs/msdosfs_vfsops.c, revision 1.148 but MFC performed by rodrigc@ was incomplete, so the "-l" option of mount_msdosfs does just nothing for 6-STABLE. >How-To-Repeat: Mount FAT that does not contain long file names in root directory and try to create long file name there. >Fix: Complete MFC of revision 1.148 for msdosfs_vfsops.c: --- sys/fs/msdosfs/msdosfs_vfsops.c.orig 31 Oct 2005 15:41:20 -0000 1.147 +++ sys/fs/msdosfs/msdosfs_vfsops.c 18 Nov 2005 22:34:31 -0000 1.148 @@ -163,8 +163,12 @@ pmp->pm_dirmask = v & ALLPERMS; vfs_flagopt(mp->mnt_optnew, "shortname", &pmp->pm_flags, MSDOSFSMNT_SHORTNAME); + vfs_flagopt(mp->mnt_optnew, "shortnames", + &pmp->pm_flags, MSDOSFSMNT_SHORTNAME); vfs_flagopt(mp->mnt_optnew, "longname", &pmp->pm_flags, MSDOSFSMNT_LONGNAME); + vfs_flagopt(mp->mnt_optnew, "longnames", + &pmp->pm_flags, MSDOSFSMNT_LONGNAME); vfs_flagopt(mp->mnt_optnew, "kiconv", &pmp->pm_flags, MSDOSFSMNT_KICONV); Eugene Grosbein >Release-Note: >Audit-Trail: >Unformatted: