From owner-cvs-src@FreeBSD.ORG Fri Nov 30 20:48:38 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 343E216A418; Fri, 30 Nov 2007 20:48:38 +0000 (UTC) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (overcee.wemm.org [IPv6:2001:5a8:4:2140::3]) by mx1.freebsd.org (Postfix) with ESMTP id F391013C45D; Fri, 30 Nov 2007 20:48:37 +0000 (UTC) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (8.14.1/8.14.1) with ESMTP id lAUKmb4e004139; Fri, 30 Nov 2007 12:48:37 -0800 (PST) (envelope-from peter@wemm.org) Received: from localhost (localhost [[UNIX: localhost]]) by overcee.wemm.org (8.14.1/8.14.1/Submit) id lAUKmb16004138; Fri, 30 Nov 2007 12:48:37 -0800 (PST) (envelope-from peter@wemm.org) X-Authentication-Warning: overcee.wemm.org: peter set sender to peter@wemm.org using -f From: Peter Wemm To: Joe Marcus Clarke Date: Fri, 30 Nov 2007 12:48:37 -0800 User-Agent: KMail/1.9.6 References: <200711290634.lAT6YUpr004269@repoman.freebsd.org> <474EF1D5.7070103@FreeBSD.org> In-Reply-To: <474EF1D5.7070103@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711301248.37322.peter@wemm.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Peter Wemm Subject: Re: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/kern kern_clock.c src/sys/sys pcpu.h resource.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2007 20:48:38 -0000 On Thursday 29 November 2007, Joe Marcus Clarke wrote: > Peter Wemm wrote: > > peter 2007-11-29 06:34:30 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/compat/linprocfs linprocfs.c > > sys/kern kern_clock.c > > sys/sys pcpu.h resource.h > > Log: > > Move the shared cp_time array (counts %sys, %user, %idle etc) to > > the per-cpu area. cp_time[] goes away and a new function creates a > > merged cp_time-like array for things like linprocfs, sysctl etc. > > The atomic ops for updating cp_time[] in statclock go away, and the > > scope of the thread lock is reduced. > > > > sysctl kern.cp_time returns a backwards compatible cp_time[] > > array. A new kern.cp_times sysctl returns the individual per-cpu > > stats. > > > > I have pending changes to make top and vmstat optionally show > > per-cpu stats. > > > > I'm very aware that there are something like 5 or 6 other > > versions "out there" for doing this - but none were handy when I > > needed them. > > > > I did merge my changes with John Baldwin's, and ended up > > replacing a few chunks of my stuff with his, and stealing some > > other code. > > libgtop uses the cp_time interface. Can __FreeBSD_version be bumped > for this? And thanks for doing this work. > > Joe If it uses sysctl kern.cp_time, then there is no change required... If you want to get the new per-cpu stats, then just test for the existence of kern.cp_times at runtime. There's no compile-time visible changes. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5