From owner-cvs-all@FreeBSD.ORG Tue Aug 2 19:25:15 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC11F16A41F; Tue, 2 Aug 2005 19:25:15 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 28D0043D49; Tue, 2 Aug 2005 19:25:15 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j72JPEF7015454; Tue, 2 Aug 2005 12:25:14 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j72JPEV8015453; Tue, 2 Aug 2005 12:25:14 -0700 Date: Tue, 2 Aug 2005 12:25:14 -0700 From: Brooks Davis To: John Baldwin Message-ID: <20050802192514.GB19107@odin.ac.hmc.edu> References: <200508021743.j72HhZRj009221@repoman.freebsd.org> <200508021416.33768.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline In-Reply-To: <200508021416.33768.jhb@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_var.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2005 19:25:15 -0000 --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 02, 2005 at 02:16:32PM -0400, John Baldwin wrote: > On Tuesday 02 August 2005 01:43 pm, Robert Watson wrote: > > rwatson 2005-08-02 17:43:35 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net if_var.h > > Log: > > Add if_addr_mtx to struct ifnet, a mutex to protect ifnet-related add= ress > > lists. Add accessor macros. > > > > This changes the size of struct ifnet, but ideally, all ifnet consume= rs > > are now using if_alloc() to allocate these structures rather than > > embedding them into device driver softc's, so this won't modify the > > network device driver ABI. > > > > MFC after: 1 week >=20 > It still modifies the ABI because of all the code that does 'ifp->if_foo'= =20 > unless you've added it to the end. He did. I should add some comments about this though. FWIW, any consumers not using if_alloc() are jumping through some major hoops to avoid a panic on if_attach() and asking for it. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFC78iZXY6L6fI4GtQRAlaVAKDWZ9tgCtOW0wChXhzjxNsiprkLxACgmYNp AAGtVqXwCcBMDaHPLDcnD8Q= =Gs54 -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML--