From owner-svn-src-head@freebsd.org Fri Sep 15 11:58:22 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0ED85E10FFE; Fri, 15 Sep 2017 11:58:22 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mailout.stack.nl (mailout05.stack.nl [IPv6:2001:610:1108:5010::202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mailout.stack.nl", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CE7F864277; Fri, 15 Sep 2017 11:58:21 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from toad2.stack.nl (toad2.stack.nl [IPv6:2001:610:1108:5010::161]) by mailout.stack.nl (Postfix) with ESMTP id 3AC7941; Fri, 15 Sep 2017 13:58:19 +0200 (CEST) Received: by toad2.stack.nl (Postfix, from userid 1677) id 33E5D89294; Fri, 15 Sep 2017 13:58:19 +0200 (CEST) Date: Fri, 15 Sep 2017 13:58:19 +0200 From: Jilles Tjoelker To: Ed Schouten Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323177 - in head: sys/compat/cloudabi sys/contrib/cloudabi usr.bin/truss Message-ID: <20170915115819.GA22099@stack.nl> References: <201709050746.v857kjX9032212@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201709050746.v857kjX9032212@repo.freebsd.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 11:58:22 -0000 On Tue, Sep 05, 2017 at 07:46:45AM +0000, Ed Schouten wrote: > Author: ed > Date: Tue Sep 5 07:46:45 2017 > New Revision: 323177 > URL: https://svnweb.freebsd.org/changeset/base/323177 > Log: > Merge pipes and socket pairs. > Now that CloudABI's sockets API has been changed to be addressless and > only connected socket instances are used (e.g., socket pairs), they have > become fairly similar to pipes. The only differences on CloudABI is that > socket pairs additionally support shutdown(), send() and recv(). > To simplify the ABI, we've therefore decided to remove pipes as a > separate file descriptor type and just let pipe() return a socket pair > of type SOCK_STREAM. S_ISFIFO() and S_ISSOCK() are now defined > identically. Although this is correct from a functionality point of view (S_IFIFO and S_IFSOCK are probably expected to be different in a POSIX context, but this is unlikely to break anything that is not already broken), it is a partial reversal of previous changes to FreeBSD that created separate implementations for pipes (first unnamed pipes in 1996, later fifos in 2012 r232055). The main reason for these changes was performance. Unfortunately, I do not have concrete benchmarks in the CloudABI context. -- Jilles Tjoelker