From nobody Mon Apr 11 20:58:39 2022 X-Original-To: pkgbase@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D661111F81C4 for ; Mon, 11 Apr 2022 20:58:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kch6752Hrz3lRn for ; Mon, 11 Apr 2022 20:58:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8CF43218B for ; Mon, 11 Apr 2022 20:58:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23BKwdkn091830 for ; Mon, 11 Apr 2022 20:58:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23BKwdaa091829 for pkgbase@FreeBSD.org; Mon, 11 Apr 2022 20:58:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: pkgbase@FreeBSD.org Subject: [Bug 254797] pkgbase: -dev packages with names containing '_' have incorrect dependencies. Date: Mon, 11 Apr 2022 20:58:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: emaste@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pkgbase@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Packaging the FreeBSD base system List-Archive: https://lists.freebsd.org/archives/freebsd-pkgbase List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkgbase@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649710719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dGoYHC6bk/f8KwEHBBdXRs90BVjuX08Iamy74oypCZk=; b=DW4FnqEcRVO/IYnicEvT/y7uI5NR6Dbcz5BJxWXacPREwwISCCBYxHz0/PGPGyx6vWEA9Z 1kRz2lfpBXxAmlxt7xn6e9StQk08hEcJetfhSCr5ZKgJFsQeXwDd4H54aoGdtLK2t5uqVH RXS4I1vzBs6YVT5JbD1Te4tHAodyMbAOf/7IHKAn4C0WsqFeAqIZNATVqIggC63OTIi27u icjl3kL0GgkuYrSdj4He5kJ+eRLP15snfyVco06HoZlFHc2VYP2PccPG6woRYxSn1c8ElM gpWoMlJE/v1MBUhlwjilX82cURXy0T/UWJkeSipGO4ImVLN7QV1gFzcRiwECZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649710719; a=rsa-sha256; cv=none; b=PiPFVV+h/5IvGDmdYJawB0exOxmTQZ7kr9hzIunfj70yfp3P37riQT3auxDpi8a6LPCHtA QwpBJwMBu1fFUKQ45gCgpBAX8ea1TjvEcKqyPec2dpPn58oDzYIiiJ1tEpwlXhbrRoH4ta VirshxyJoI4Gaf8bQlNkaglB+4zo3iF1tewtCVDWO2HTG59KuNCRje/n+zbo9gkxVz1jPB x7BYBYhk77zdYs1OmffT1yHK/OpbbM/1+FddUCW7CJ1ifAjWA5it95sPMJFYcucnfLmzyK Z4k8Qvp/ZtHVD3L6+liWh7onCZKRZoFDs9KRbKnN+9w2OdvQt9EKoZNRoFXi1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254797 Ed Maste changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org --- Comment #1 from Ed Maste --- Just discovered this commit: commit 09d83a060f37ba17b29c0e90f3a0e9aa9c735592 Author: Mark Johnston Date: Mon Apr 26 15:15:31 2021 -0400 pkgbase: Remove package name mangling in generate-ucl.sh The mangling was present in the initial revision of the script, but its purpose is not clear. It may have been to avoid defining make(1) variables with a dash in the name, but this is permitted. Furthermore, it results in invalid dependency information if a dependency's name contains an underscore, causing e.g., libcompiler_rt-dev to depend on libcompiler-rt, and resulting in warnings when installing base system packages. Remove the mangling. Reviewed by: manu MFC after: 2 months Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D29883 release/packages/generate-ucl.sh | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=