From owner-freebsd-current@FreeBSD.ORG Wed Oct 22 08:54:55 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0EAEC16A4BF; Wed, 22 Oct 2003 08:54:55 -0700 (PDT) Received: from creme-brulee.marcuscom.com (rdu74-159-108.nc.rr.com [24.74.159.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 547FB43FAF; Wed, 22 Oct 2003 08:54:51 -0700 (PDT) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.4] (vpn-client-4.marcuscom.com [10.2.1.4]) h9MFraMN013956; Wed, 22 Oct 2003 11:53:36 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Andreas Klemm In-Reply-To: <20031022153138.GA4102@titan.klemm.apsfilter.org> References: <20031022113039.GA10053@titan.klemm.apsfilter.org> <3F969491.5000405@openet-telecom.com> <20031022153138.GA4102@titan.klemm.apsfilter.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-+Wu2vlNoEBcq1T8F+N9k" Organization: MarcusCom, Inc. Message-Id: <1066837963.720.0.camel@gyros> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Wed, 22 Oct 2003 11:54:49 -0400 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.60 X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on creme-brulee.marcuscom.com cc: current@freebsd.org cc: portmgr@freebsd.org Subject: Re: Approval for Hotfix needed for portscanner (was Re: Error assigning master socket: Too many open files) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2003 15:54:55 -0000 --=-+Wu2vlNoEBcq1T8F+N9k Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2003-10-22 at 11:31, Andreas Klemm wrote: > On Wed, Oct 22, 2003 at 03:30:41PM +0100, Peter Edwards wrote: > > The patch applied by the port appears bogus. It adds braces around an=20 > > "if" that stops it executing the way it was intended. I've a sneaking=20 > > suspicion that the braces were added for "clarity", but the indentation= =20 > > in the original file is so badly off that the terminating brace was put= =20 > > in the wrong place. Try replacing patch-ab with this: > >=20 > > --- portscanner.c.orig Wed Aug 19 18:37:44 1998 > > +++ portscanner.c Wed Oct 22 15:28:05 2003 > > @@ -25,8 +25,8 @@ > > /***********************************************************/ > >=20 > > #include > > -#include > > #include > > +#include > > #include > > #include > > #include >=20 > Hi Peter, >=20 > thanks a lot for your help. You're completely right with your > diagnose and fix. >=20 > I'll put portmgr@ on Cc: to be allowed to commit the change > and will happily apply your fix to the port if I get the approval. >=20 > look here: >=20 > root@titan[ttyp2]{82} /usr/ports/security/portscanner portscanner -b 1 -e= 60000 -vv xx.xx.xx.xxx > Resolving: xx.xx.xx.xxx -> resolved > Current address: xx.xx.xx.xxx > Port range: 1 to 60000 > Port 135 found. Service name: loc-srv > Port 445 found. Service name: microsoft-ds > Port 1025 found. Service name: blackjack >=20 > Port scan finished ! >=20 > After changing the patch and reinstalling the port, > the portscanner is completely functional again now. Go for it. Joe >=20 > Best regards >=20 > Andreas /// --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-+Wu2vlNoEBcq1T8F+N9k Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQA/lqfLb2iPiv4Uz4cRAgWxAKCmc+3olI7vxayeZUdvdDkSmWaRlwCfY39n V6kPEvB+8wfOFt/oYY1mjiQ= =5SHw -----END PGP SIGNATURE----- --=-+Wu2vlNoEBcq1T8F+N9k--