Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 1 Apr 2008 20:53:32 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   cvs commit: src/sys/dev/aac aac.c
Message-ID:  <200804012053.m31KrWAl010090@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
emaste      2008-04-01 20:53:32 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/aac          aac.c 
  Log:
  Calling RequestSupplementAdapterInfo before RequestAdapterInfo appears
  to trip a bug causing the latter to return a zeroed struct
  aac_adapter_info.  This causes two issues.  One is cosmetic only --
  a verbose boot prints information about the controller, and shows all
  zero:
  
  aac0: Unknown processor 0MHz, 0MB memory (0MB cache, 0MB execution),
    unknown battery platform
  
  The second problem is that the firmware version information is stored
  away for aac_rev_check, for userland tools (like aaccli) to query via
  the FSACTL_MINIPORT_REV_CHECK and FSACTL_LNX_MINIPORT_REV_CHECK ioctls.
  When aaccli encounters this issue it prints
  
  Command Error: <The current AFAAPI.DLL is too old to work with the
    current controller software.>
  
  Move the RequestSupplementAdapterInfo call after RequestAdapterInfo,
  which seems to fix both problems.
  
  Revision  Changes    Path
  1.137     +17 -17    src/sys/dev/aac/aac.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200804012053.m31KrWAl010090>