From owner-freebsd-stable@FreeBSD.ORG Sun Jan 20 20:27:36 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76EF016A417 for ; Sun, 20 Jan 2008 20:27:36 +0000 (UTC) (envelope-from torfinn.ingolfsen@broadpark.no) Received: from osl1smout1.broadpark.no (osl1smout1.broadpark.no [80.202.4.58]) by mx1.freebsd.org (Postfix) with ESMTP id 42E8713C4DB for ; Sun, 20 Jan 2008 20:27:36 +0000 (UTC) (envelope-from torfinn.ingolfsen@broadpark.no) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII Received: from osl1sminn1.broadpark.no ([80.202.4.59]) by osl1smout1.broadpark.no (Sun Java(tm) System Messaging Server 6.3-3.01 (built Jul 12 2007; 32bit)) with ESMTP id <0JUY00LI4M5YBLA0@osl1smout1.broadpark.no> for freebsd-stable@freebsd.org; Sun, 20 Jan 2008 21:27:34 +0100 (CET) Received: from kg-work.kg4.no ([80.202.173.59]) by osl1sminn1.broadpark.no (Sun Java(tm) System Messaging Server 6.3-3.01 (built Jul 12 2007; 32bit)) with SMTP id <0JUY00H3CM5WEYN5@osl1sminn1.broadpark.no> for freebsd-stable@freebsd.org; Sun, 20 Jan 2008 21:27:34 +0100 (CET) Date: Sun, 20 Jan 2008 21:27:32 +0100 From: Torfinn Ingolfsen To: freebsd-stable@freebsd.org Message-id: <20080120212732.f3ea3fe1.torfinn.ingolfsen@broadpark.no> In-reply-to: <4792BC5E.4030703@vwsoft.com> References: <4792BC5E.4030703@vwsoft.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.3; i386-portbld-freebsd6.3) X-Face: "t9w2,-X@O^I`jVW\sonI3.,36KBLZE*AL[y9lL[PyFD*r_S:dIL9c[8Y>V42R0"!"yb_zN,f#%.[PYYNq; m"_0v; ~rUM2Yy!zmkh)3&U|u!=T(zyv,MHJv"nDH>OJ`t(@mil461d_B'Uo|'nMwlKe0Mv=kvV?Nh@>Hb<3s_z2jYgZhPb@?Wi^x1a~Hplz1.zH Subject: Re: patch for review: ATI SB600 SATA AHCI X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jan 2008 20:27:36 -0000 Hello, On Sun, 20 Jan 2008 04:13:34 +0100 Volker wrote: > 6715b notebook using ATI SB-600 chipset. With stock kernel, the ATA I have a machine with an Asus M2A-VM HDMI motherboard[1], which also have this chipset. > My patch has been tested on RELENG_7 as of 2008-01-19. Please review, > check and test if possible. Should work on 8-CURRENT, too. I had to hand apply part of the patch (probably a whitespace problem when I copied it from the mail), but it built fine. >From dmesg, before the patch: atapci0: port 0xfc00-0xfc07,0xf800-0xf803,0xf400-0xf407,0xf000-0xf003,0xec00-0xec0f mem 0xfe02f000-0xfe02f3ff irq 22 at device 18.0 on pci0 atapci0: [ITHREAD] ata2: on atapci0 ata2: [ITHREAD] ata3: on atapci0 ata3: [ITHREAD] atapci1: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xe400-0xe40f at device 20.1 on pci0 ata0: on atapci1 ata0: [ITHREAD] acd0: DVDR at ata0-master UDMA66 ad4: 476940MB at ata2-master UDMA33 >From dmesg, after the patch: tapci0: port 0xfc00-0xfc07,0xf800-0xf803,0xf400-0xf407,0xf000-0xf003,0xec00-0xec0f mem 0xfe02f000-0xfe02f3ff irq 22 at device 18.0 on pci0 atapci0: [ITHREAD] atapci0: AHCI Version 01.10 controller with 4 ports detected ata2: on atapci0 ata2: [ITHREAD] ata3: on atapci0 ata3: [ITHREAD] ata4: on atapci0 ata4: [ITHREAD] ata5: on atapci0 ata5: [ITHREAD] atapci1: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xe400-0xe40f at device 20.1 on pci0 ata0: on atapci1 ata0: [ITHREAD] acd0: DVDR at ata0-master UDMA66 ad4: 476940MB at ata2-master SATA300 I haven't done any tests to see if it changes performance in any way, at least it reports SATA 300: root@kg-vm# atacontrol mode ad4 current mode = SATA300 This is on: root@kg-vm# uname -a FreeBSD kg-vm.kg4.no 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #4: Sun Jan 20 19:27:36 CET 2008 root@kg-vm.kg4.no:/usr/obj/usr/src/sys/GENERIC amd64 References: 1) info about my machine http://tingox.googlepages.com/asus_m2a-vm_hdmi -- Regards, Torfinn Ingolfsen