From owner-cvs-all Sun Feb 28 19:12:41 1999 Delivered-To: cvs-all@freebsd.org Received: from picnic.mat.net (picnic.mat.net [206.246.122.133]) by hub.freebsd.org (Postfix) with ESMTP id BB8B0151D3; Sun, 28 Feb 1999 19:12:35 -0800 (PST) (envelope-from chuckr@mat.net) Received: from localhost (chuckr@localhost) by picnic.mat.net (8.9.3/8.8.5) with ESMTP id WAA50670; Sun, 28 Feb 1999 22:11:11 -0500 (EST) Date: Sun, 28 Feb 1999 22:11:11 -0500 (EST) From: Chuck Robey To: Garrett Wollman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libmd Makefile sha.3 In-Reply-To: <199903010239.SAA57887@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sun, 28 Feb 1999, Garrett Wollman wrote: > wollman 1999/02/28 18:39:45 PST > > Modified files: > lib/libmd Makefile sha.3 > Log: > Don't even attempt to build the assembly-language versions of RIPEMD160 > and SHA-1 when OBJFORMAT is not ELF. Add a warning to the man page > about how SHA-1 uses bswapl, which will trap on 80386es (and the kernel > should, but doesn't currently, emulate). I notice you mention the traps ... does that mean, during the time window between when I committed John Polstra's suggestion about .align (making both sha.S and rmd160.S compile for both elf and aout) and your commit here completely disabling the building, someone could build a kernel that would panic on a 386 processor? If that's true, it would kinda require at least a pretty clear warning here, which is why I'm asking. I know it's a small time window, and only for those running 386's, but fair is fair (if I caused this). You did see my earlier commits to i386/sha.S and i386/rmd160.S, right? When you didn't reply this morning, since the buildworld was broken (and thus I didn't want to wait) I went ahead and stuck in what seemed like the most minimal fix. ----------------------------+----------------------------------------------- Chuck Robey | Interests include any kind of voice or data chuckr@glue.umd.edu | communications topic, C programming, and Unix. 213 Lakeside Drive Apt T-1 | Greenbelt, MD 20770 | I run picnic (FreeBSD-current) (301) 220-2114 | and jaunt (Solaris7). ----------------------------+----------------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message