Date: Mon, 5 Jun 2017 17:50:06 -0600 From: Adam Weinberger <adamw@adamw.org> To: "Sergey A. Osokin" <osa@FreeBSD.org> Cc: Bartek Rutkowski <robak@FreeBSD.org>, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r442588 - in head/www: nginx nginx-full Message-ID: <C38A2113-0736-4687-91D8-D49722D61E35@adamw.org> In-Reply-To: <20170605001807.GA55217@FreeBSD.org> References: <201706042038.v54KcQMf001482@repo.freebsd.org> <20170605001807.GA55217@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 4 Jun, 2017, at 18:18, Sergey A. Osokin <osa@FreeBSD.org> wrote: >=20 > Hi Bartek and Adam, >=20 > I don't think I can get this, so two questions for you guys: > o) what was the reason to bump PORTREVISION in www/nginx? > o) wouldn't it btter to just bump PORTREVISION in www/nginx-full? Hi Sergey, I'll give Bartek a chance to explain in more detail, but I supported an = nginx bump because it was less complex for the future. If nginx-full got a bump, then it would need to be bumped every time = nginx got bumped, or nginx would have to be bumped by two and = nginx-full's PORTREVISION line gets removed, and then the line has to be = removed at the next nginx update or reset. At the end of the day, = bumping nginx was more straightforward. It triggers an update for = everyone else, but becomes less invasive over the long haul. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org >=20 > -- > Sergey Osokin >=20 > On Sun, Jun 04, 2017 at 08:38:26PM +0000, Bartek Rutkowski wrote: >> Author: robak >> Date: Sun Jun 4 20:38:26 2017 >> New Revision: 442588 >> URL: https://svnweb.freebsd.org/changeset/ports/442588 >>=20 >> Log: >> www/nginx and www/nginx-full: remove obsolete modules and bump = PORTREVISION >>=20 >> Some time ago www/nginx master port removed two external modules = that >> stayed in www/nginx-full slave port options causing pkg build = failures. >> Thich change removes the modules from www/nginx-full and bumps = www/nginx >> PORTREVISION to force revision bump for slave port. >>=20 >> Approved by: portmgr (adamw) >>=20 >> Modified: >> head/www/nginx-full/Makefile >> head/www/nginx/Makefile >>=20 >> Modified: head/www/nginx-full/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/www/nginx-full/Makefile Sun Jun 4 20:35:48 2017 = (r442587) >> +++ head/www/nginx-full/Makefile Sun Jun 4 20:38:26 2017 = (r442588) >> @@ -22,7 +22,7 @@ OPTIONS_DEFAULT=3DDSO DEBUG DEBUGLOG FILE_AIO = GOOGLE_PER >> HTTP_SSL HTTP_STATUS HTTP_SUB HTTP_XSLT MAIL MAIL_IMAP \ >> MAIL_POP3 MAIL_SMTP MAIL_SSL HTTPV2 NJS STREAM = STREAM_SSL \ >> THREADS WWW AJP AWS_AUTH CACHE_PURGE CLOJURE CT ECHO \ >> - FASTDFS HEADERS_MORE HTTP_ACCEPT_LANGUAGE HTTP_ACCESSKEY = \ >> + FASTDFS HEADERS_MORE HTTP_ACCEPT_LANGUAGE \ >> HTTP_AUTH_DIGEST HTTP_AUTH_KRB5 HTTP_AUTH_LDAP = HTTP_AUTH_PAM \ >> HTTP_DAV_EXT HTTP_EVAL HTTP_FANCYINDEX HTTP_FOOTER \ >> HTTP_GEOIP2 HTTP_JSON_STATUS HTTP_MOGILEFS HTTP_MP4_H264 = \ >> @@ -34,6 +34,6 @@ OPTIONS_DEFAULT=3DDSO DEBUG DEBUGLOG FILE_AIO = GOOGLE_PER >> FORMINPUT GRIDFS ICONV LET LUA MEMC MODSECURITY \ >> NAXSI PASSENGER POSTGRES RDS_CSV RDS_JSON REDIS2 \ >> RTMP SET_MISC SFLOW SHIBBOLETH SLOWFS_CACHE SMALL_LIGHT = \ >> - SRCACHE STATSD UDPLOG X11 XRID_HEADER XSS >> + SRCACHE STATSD UDPLOG X11 XSS >>=20 >> .include "${MASTERDIR}/Makefile" >>=20 >> Modified: head/www/nginx/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/www/nginx/Makefile Sun Jun 4 20:35:48 2017 = (r442587) >> +++ head/www/nginx/Makefile Sun Jun 4 20:38:26 2017 = (r442588) >> @@ -3,7 +3,7 @@ >>=20 >> PORTNAME=3D nginx >> PORTVERSION=3D 1.12.0 >> -PORTREVISION?=3D 3 >> +PORTREVISION?=3D 4 >> PORTEPOCH=3D 2 >> CATEGORIES=3D www >> MASTER_SITES=3D http://nginx.org/download/ >>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C38A2113-0736-4687-91D8-D49722D61E35>