From nobody Mon Feb 6 18:35:10 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P9Zgh1b6dz3n2yV; Mon, 6 Feb 2023 18:35:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P9Zgh0sJ0z3LJx; Mon, 6 Feb 2023 18:35:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675708512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WaZK17q6Z/RhL39FF84/zh4ZjB1/9FOF66CNMPoos6Q=; b=CRbC+TknbHfXImw2P4gnFhVKtMGqKXNhjjhEJHJVFkX+ezsXWEB0hAPldTXr6zMUdKuvAS tTth4+MI3XCgNTlkZB3nns9iesqRRF4S/+Lszy7FLEuUsjH7f1xIcCVHfWnHHycAvvR2CI zQz9vIhQUpjby93q8LBr+RDMTGGcsiiFjlx8bVAewYoI491AotNDf3ABfRiidiqMuRuKAQ P9a2qNh9uuXCVwN/QoxtCQW4sQZwTI61dYGNoxbFdf99r+9MGb1/4WGIQqNuNz/0gyE/Qv sFs3/lr6VbVbCKzGdnCvwWmz63yqS/RuuX3jj4ItR94umTBTG6RxF2rEFs9B3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675708512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WaZK17q6Z/RhL39FF84/zh4ZjB1/9FOF66CNMPoos6Q=; b=PgqGjBj6I5u5ROH2MV1yApN0XOXBWx1U8ZGU3B/K3Q1QWeyk69m8gk95Lk+2MsvjYsiL42 qzygJCe3DTOBrzIApYCVzW6XFKKtmXY+/v/8+bppBcWk4h/ghdDZdUgtr4sP65qXkztwvY fMvOtorZHNPwvhowN56r9V9ecKLZwNupml5Qc4AmHpIpSuSxJXi7gJ1hcfj4QIKrXt8niF 2VFY6WaKWIWiO9Vv3a7lPHjIEUo6ttY20eK3NmKny0S1Z0TJZ6H8iK0ETWuQveyuw/5qj5 a3S7ECqAubVkZMGaPgXth9q7NEZvx9gJo+EG2Q885arxwlj1WLjcpn7SvRux4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675708512; a=rsa-sha256; cv=none; b=C67vDVUseQfJ9Qv2XPcUfMxhlieiFPr1t3BK389Rcmef/C7j5ov6rszIy/HjVMcJ/pgyJG q9nK9xpMdwxPSKu+/om3eLva8vhGefsFF8Sucrczh0pNGYylGZvwnn0nzv9XeI/RiLIzA9 /C8STmPdXm+4RuXek+nbgI/gzNlpQ/2sqWEps3V7yZXCzQIYX0BDvwILjqQZVRWsRtWR+G 9gSuK5HeIHe3mpGLX+n11QOkOmY1Lxswxl/AvaPMzH5QaWffFrz4lQDy97gN8gQUb8ruzQ NjbYX8wcmKN2Z1rSTYiCo06EQn4mFOa1DLcWXpujgNpmYn9MSJiNJVuKEYGFoQ== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P9Zgg3b4Sz1Mk9; Mon, 6 Feb 2023 18:35:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <68741cc8-67eb-747f-c5fc-f46521dc712c@FreeBSD.org> Date: Mon, 6 Feb 2023 10:35:10 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: git: 6926e2699ae5 - main - arm: Add support for using VFP in kernel Content-Language: en-US To: =?UTF-8?Q?Kornel_Dul=c4=99ba?= , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202302041922.314JMNEp076075@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202302041922.314JMNEp076075@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 2/4/23 11:22 AM, Kornel Dulęba wrote: > The branch main has been updated by kd: > > URL: https://cgit.FreeBSD.org/src/commit/?id=6926e2699ae55080f860488895a2a9aa6e6d9b4d > > commit 6926e2699ae55080f860488895a2a9aa6e6d9b4d > Author: Kornel Dulęba > AuthorDate: 2023-02-04 12:59:30 +0000 > Commit: Kornel Dulęba > CommitDate: 2023-02-04 19:21:43 +0000 > > arm: Add support for using VFP in kernel > > Add missing logic to allow in-kernel VFP usage for ARMv7 NEON. > The implementation is strongly based on arm64 code. > It introduces a family of fpu_kern_* functions to enable the usage > of VFP instructions in kernel. > Apart from that the existing armv7 VFP logic was modified, > taking into account that the state of the VFP registers can now > be modified in the kernel. > > Co-developed by: Wojciech Macek > Sponsored by: Stormshield > Obtained from: Semihalf > Reviewed by: andrew > Differential Revision: https://reviews.freebsd.org/D37419 Note that changing the layout of 'struct fpreg' and what fill_fpregs and set_fpregs do does change the layout of the .reg2 coredump note and what happens for PT_[GS]ETFPREGS for ptrace(2). That said, GDB at least ignores all that since it is known to be useless. I haven't checked LLDB, but it likely doesn't care about the old interfaces either. Maybe at least a RELNOTES entry and __FreeBSD_version bump in case it is problematic in the future? > --- > lib/libthread_db/arch/arm/libpthread_md.c | 21 ++-- > sys/arm/arm/exec_machdep.c | 49 ++++---- > sys/arm/arm/machdep.c | 1 + > sys/arm/arm/machdep_kdb.c | 31 ++++- > sys/arm/arm/swtch-v6.S | 8 +- > sys/arm/arm/swtch.S | 8 +- > sys/arm/arm/vfp.c | 182 +++++++++++++++++++++++++++++- > sys/arm/arm/vm_machdep.c | 6 +- > sys/arm/include/fpu.h | 7 ++ > sys/arm/include/pcb.h | 5 + > sys/arm/include/reg.h | 12 +- > sys/arm/include/vfp.h | 17 +++ > 12 files changed, 293 insertions(+), 54 deletions(-) > > diff --git a/sys/arm/arm/exec_machdep.c b/sys/arm/arm/exec_machdep.c > index 2bf3efff7fe4..c14bd51146ef 100644 > --- a/sys/arm/arm/exec_machdep.c > +++ b/sys/arm/arm/exec_machdep.c > @@ -100,16 +100,18 @@ get_vfpcontext(struct thread *td, mcontext_vfp_t *vfp) > memcpy(vfp->mcv_reg, pcb->pcb_vfpstate.reg, > - sizeof(vfp->mcv_reg)); > + sizeof(vfp->mcv_reg)); FYI, this was a style regression here and elsewhere in the commit. -- John Baldwin