Date: Tue, 21 Feb 2017 14:50:32 -0800 From: prabhakar lakhera <prabhakar.lakhera@gmail.com> To: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Bug in ICMP redirect handling Message-ID: <CALg%2BrhUBr7q0jamGgzRbFreMnjRg%2B-qvNiH95D8O4iO34u=%2BiA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
This seems like a bug: https://svnweb.freebsd.org/base/head/sys/netinet/tcp_subr.c?r1=303457&r2=303456&pathrev=303457 I believe the ordering of if/else checks for cmd value is important as the last one checks for mapping of PRC* to an error. Given that the mapping is defined to be 0 for redirects (only cached routes are supposed to be invalidated), looks like right now we'll simply return from: else if ((unsigned)cmd >= PRC_NCMDS || *inetctlerrmap[cmd] == 0)* return; The above is I guess is only in the head and not in a major version yet.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALg%2BrhUBr7q0jamGgzRbFreMnjRg%2B-qvNiH95D8O4iO34u=%2BiA>